New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make update-*dependencies.sh runnable on Mac #15823
Conversation
update-extension-dependencies.sh
Outdated
echo '' | ||
echo 'Building entire project...' | ||
echo '' | ||
mvn -q -e -Dquickly -T0.8C $* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stderr outputs leak through here, e.g. some Gradle stuff.
We could either live with it or print everything. Redirecting stderr to /dev/null
is not a good idea in case there is a build error.
update-extension-dependencies.sh
Outdated
@@ -32,7 +46,7 @@ echo '' | |||
# get all "artifact-id" values from the generated json file | |||
# pipefail is switched off briefly so that a better error can be logged when nothing is found | |||
set +o pipefail | |||
ARTIFACT_IDS=`grep '^ "artifact"' devtools/bom-descriptor-json/target/*.json | grep -Po '(?<=io.quarkus:)(?!quarkus-bom)[^:]+' | sort` | |||
ARTIFACT_IDS=`grep '^ "artifact"' devtools/bom-descriptor-json/target/*.json | grep -Eo 'quarkus-[a-z0-9-]+' | sort` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The quarkus-bom
exclusion is not required anymore since the recent descriptor change.
Running:
I get a warning: |
Did you run that in |
Nuts, ran it in the wrong spot. Can confirm But running the script in |
I'll see if I can improve that.
I guess this is the case: https://apple.stackexchange.com/questions/275373/how-to-make-grep-work-like-in-ubuntu/275379 I suppose this hangs as well?
What about this?
|
First version also has recursive search warning and sits there not showing anything. Second one, ending in "." works instantly returning the implementation and test implementation artifact names |
Cool, thanks! I'll adjust the scripts and ping you again, for the last time I hope. |
@gsmet Since you asked for the full build feature: Any change requests? |
@kenfinnigan Can you retry please? The scripts should now also be callable from everywhere, e.g. |
Both scripts now fail with the following error:
|
This is the gift that keeps on giving. 😞 I hope https://stackoverflow.com/questions/3572030/bash-script-absolute-path-with-os-x#comment64141768_3572030 is right, works on Ubuntu. @kenfinnigan Can you try again please? |
Running the extension dependencies in root gives me:
Same error with the gradle script from root |
@kenfinnigan ... aaand another round! No much left to break. 😒 |
Running extension dependencies in root gives the below error, what looks like for every artifact:
Gradle script fails with similar error, but different line numbers:
|
*sigh* ... what is this giving you (in root)?
|
It lists the artifacts names |
That's good. 😉 But does any of those contain a |
None |
Then it must be having a problem with
|
@kenfinnigan Another try please. It's a shot in the dark... PS: I did have a look at how to (theoretically) set up a OSX virtualbox...but I have definitely no time for this ATM, unfortunately. |
Error is still unexpected EOF while looking for matching `'' for both scripts |
@kenfinnigan Can you please re-run the script for gradle and post the entire output here? Thanks! |
Here's the output:
|
Oh, this is so much fun. 😜 @kenfinnigan I pushed another change. |
I get:
|
with content:
|
@kenfinnigan another try please? thanks! |
So close! It doesn't fail now, but there is a slight difference in each of the files:
|
Very odd. BSD |
Same result, |
I've given up on having one sed expression do exactly the same thing for both GNU and BSD and so I have added another expression to fix that missing line break. |
The closing dependencies tag is still in on the same line as the comment |
BSD sed hates me. To clarify, you see this problem in:
? |
Ah, I had forgotten to add that fixup expression to the |
|
Fix pushed. The suspension is killing me! 😉 |
I just tested it for the addition of avro dependency, and it works on my mac :) thanks! |
Ah, finally! Thanks for letting me know, @glefloch! |
actually, the script is working but the output does not seems to be the same as the previous one: |
@glefloch did you pick up the latest commit? My last update was half a day ago. |
On my local machine yes. |
so i run both version of the script and the output is the same. sorry the noise 👼 |
I've verified the scripts work and don't result in any changeset. Thanks @famod! Not sure why CI is failing, maybe just needs a rebase? |
Thanks for your patience, @kenfinnigan! I'll check CI tomorrow. I definitely won't merge if CI failures are related so it would be great if you could approve this PR. Thanks! |
I decided to rebase to give CI another go. |
Test Failures⚙️ jvm-linux-jdk15📦 extensions/mongodb-client/deployment# Tests: 11
+ Success: 10
- Failures: 0
- Errors: 1
! Skipped: 0 ❌
|
@gsmet FYI, two jobs failed here. The bot has picked up that one test failure successfully ^ but the other job failed with:
So we should monitor how people get along, in the sense that you cannot rely on the bot to extract all failure reasons for you. |
Change tested on Ubuntu 20.04 and Windows 10 (Git Bash).
@kenfinnigan I'd appreciate if you could test those two scripts on Mac. Thanks!
/cc @gsmet
FTR: Came up here: #15016 (comment)