Clear the /tmp folder on first dev mode start #15849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/graphql
area/health
area/smallrye
area/swagger-ui
area/vertx
labels
|
Frankly, I think in dev mode, we should push that content to the build dir e.g. We would probably have to clean it anyway but at least a clean would clean it too. |
|
@gsmet thanks. Do you want me to do that now as part of this PR? Or as a follow up? |
gsmet
reviewed
Mar 19, 2021
core/deployment/src/main/java/io/quarkus/deployment/util/WebJarUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
gsmet
approved these changes
Mar 19, 2021
gsmet
added
triage/backport?
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #15537, this PR will also clean the /tmp folder on the first mvn quarkus:dev run.
Fix #15537
Signed-off-by:Phillip Kruger phillip.kruger@gmail.com