Allow adding multiple realms #15915
Allow adding multiple realms #15915
Conversation
| builder.getValue().addRealm(realmName, realm.getValue()); | ||
| public RuntimeValue<SecurityDomain.Builder> addRealm(RuntimeValue<SecurityDomain.Builder> builder, String realmName, | ||
| RuntimeValue<SecurityRealm> realm) { | ||
| return new RuntimeValue<>(builder.getValue().addRealm(realmName, realm.getValue()).build()); |
There was a problem hiding this comment.
I agree the build() call is missing but do you really need to return the builder? It seems useless to me but I might miss something.
There was a problem hiding this comment.
Yep, it is indeed not needed, I will remove it. The build call is enough
There was a problem hiding this comment.
Cool, thanks. I squashed the two commits and force pushed. Let's wait for CI!
gsmet
added
triage/waiting-for-ci
|
@gsmet please, check this last change as it was preventing me from authenticating using the DefaultRoleDecoder. |
| }) | ||
| .setRoleDecoder(authorizationIdentity -> CDI.current() | ||
| .select(DefaultRoleDecoder.class).get() | ||
| .decodeRoles(authorizationIdentity)) |
There was a problem hiding this comment.
Please don't do that, we are not using lambdas in runtime code because it consumes memory.
There was a problem hiding this comment.
I didn't know. Will revert immediately
ruromero
force-pushed
the
multirealm
branch
2 times, most recently
from
e2ee0e6
to
edfe887
Compare
| public Roles decodeRoles(AuthorizationIdentity authorizationIdentity) { | ||
| return CDI.current().select(DefaultRoleDecoder.class).get().decodeRoles(authorizationIdentity); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Am I missing something or did you lose the call to build()? :)
There was a problem hiding this comment.
I am the one losing my head... sorry 😅
Signed-off-by: ruromero <rromerom@redhat.com>
|
Merged, thanks! |
|
@gsmet would it be possible to backport it to 1.11? For next releases of JBPM/RHPAM we will be depending on Quarkus 1.11. |
|
@ruromero sure, I already added the appropriate label as I thought it would be a good fix for 1.11. Everything with the |
|
Thanks for the clarification |
Signed-off-by: ruromero rromerom@redhat.com
When defining multiple realms only the first one was registered.