Copy Content-Type from Netty HttpResponse to APIGatewayV2HTTPResponse #16007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
previously requested changes
Mar 26, 2021
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
richiethom
force-pushed
the
quarkus_15909
branch
from
20aff96
to
6c1ff1a
Compare
|
@gsmet finally worked out how to do squash the PR, hopefully it's all ok now |
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Show resolved
Hide resolved
richiethom
force-pushed
the
quarkus_15909
branch
from
6c1ff1a
to
517ca4b
Compare
|
I've changed it all, the MultiValueHeaders stuff is now replaced with 'normal' headers. If the Header returned from Netty is multi-valued, it is concatenated with commas, as explained in the AWS API Gateway 2 documentation:
Let me know what you think. |
richiethom
force-pushed
the
quarkus_15909
branch
from
517ca4b
to
a049fca
Compare
richiethom
force-pushed
the
quarkus_15909
branch
from
a049fca
to
4a5ad6e
Compare
richiethom
force-pushed
the
quarkus_15909
branch
from
4a5ad6e
to
7dbfae1
Compare
|
hi @patriot1burke and @gsmet this is now ready for a review. |
patriot1burke
approved these changes
Mar 29, 2021
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Show resolved
Hide resolved
|
@richiethom Great job on this. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15909
If the Netty response is an HttpResponse, retrieve its Content-Type and set it on the APIGatewayV2HTTPResponse.
(my first pull request for a long time, a lot has changed, please don't hesitate to fix/squash if necessary)