Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Scheduled - add Support for Default Value and for Switching Timer Off #16073

Merged
merged 1 commit into from Apr 7, 2021

Conversation

renegrob
Copy link
Contributor

@renegrob renegrob commented Mar 27, 2021

See #16063

This implementation supports the "${propery[:defaultValue]}" style syntax with sub-string and nested property substitution. The "{property}" syntax is supported for backwards compatibility but does not support new features such as nested properties, default values and sub-string substitution.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 27, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@renegrob renegrob force-pushed the schedule-default-values branch 6 times, most recently from c376e82 to 5df2dd0 Compare March 29, 2021 11:38
@renegrob
Copy link
Contributor Author

@mkouba Can you have a quick look if this okay. I'll add some unit tests for default value, off and disabled although I'm not yet sure where they should be located: in the runtime code or in the integration-tests

@mkouba
Copy link
Contributor

mkouba commented Mar 29, 2021

@mkouba Can you have a quick look if this okay. I'll add some unit tests for default value, off and disabled although I'm not yet sure where they should be located: in the runtime code or in the integration-tests

Unit tests (for the util methods) should go in the runtime module and integration tests in the deployment module.

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Pls add the tests and don't forget to update the docs . Thanks!

@renegrob renegrob force-pushed the schedule-default-values branch 3 times, most recently from fdf3f93 to 5e38a8c Compare April 2, 2021 20:11
@renegrob renegrob marked this pull request as ready for review April 3, 2021 13:47
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added few minor comments...

add Support for Default Value and for Switching Timer Off
@mkouba mkouba added this to the 1.14 - main milestone Apr 7, 2021
@mkouba mkouba merged commit 41cbf43 into quarkusio:main Apr 7, 2021
@mkouba
Copy link
Contributor

mkouba commented Apr 7, 2021

Thanks @renegrob! I think that it's really a nice addition.

@renegrob renegrob deleted the schedule-default-values branch April 7, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants