New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Scheduled - add Support for Default Value and for Switching Timer Off #16073
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
c376e82
to
5df2dd0
Compare
@mkouba Can you have a quick look if this okay. I'll add some unit tests for default value, |
Unit tests (for the util methods) should go in the runtime module and integration tests in the deployment module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Pls add the tests and don't forget to update the docs . Thanks!
...nsions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/util/SchedulerUtils.java
Outdated
Show resolved
Hide resolved
...nsions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/util/SchedulerUtils.java
Outdated
Show resolved
Hide resolved
fdf3f93
to
5e38a8c
Compare
5e38a8c
to
4415937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added few minor comments...
...ns/scheduler/runtime/src/test/java/io/quarkus/scheduler/runtime/util/SchedulerUtilsTest.java
Show resolved
Hide resolved
...cheduler/deployment/src/test/java/io/quarkus/scheduler/test/DisabledScheduledMethodTest.java
Show resolved
Hide resolved
add Support for Default Value and for Switching Timer Off
4415937
to
adad98f
Compare
Thanks @renegrob! I think that it's really a nice addition. |
See #16063
This implementation supports the "${propery[:defaultValue]}" style syntax with sub-string and nested property substitution. The "{property}" syntax is supported for backwards compatibility but does not support new features such as nested properties, default values and sub-string substitution.