Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle test not using Java 8 #16137

Merged
merged 1 commit into from Mar 31, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 31, 2021

@glefloch could you have another look at this one? I don't understand why CI didn't catch it and only the release build process job did.

Also I wasn't able to run the test anyway (but I tried to do it from the directory itself by fixing a few properties) so I'm not sure if it's just my setup that is incorrect.

Last error I had was:

Caused by: java.util.NoSuchElementException
        at io.quarkus.deployment.builditem.ArchiveRootBuildItem.<init>(ArchiveRootBuildItem.java:97)
        at io.quarkus.deployment.builditem.ArchiveRootBuildItem.<init>(ArchiveRootBuildItem.java:17)
        at io.quarkus.deployment.builditem.ArchiveRootBuildItem$Builder.build(ArchiveRootBuildItem.java:50)
        at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:141)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:394)

Is there an easy way to only run one Gradle test?

@gsmet gsmet requested a review from glefloch March 31, 2021 09:36
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Mar 31, 2021
@glefloch
Copy link
Member

@gsmet good catch!

I think the gradle CI runs only with java 11, whereas the release job is using java 8. Maybe we should switch the gradle ci to java 8?

If you only want to run this test, you can do it with;

./gradlew clean test --tests MultiModuleWithEmptyModuleDevModeTest

I'm building quarkus locally to test your fix, I never remember if it's 8 or 1.8 for java version.

@gsmet
Copy link
Member Author

gsmet commented Mar 31, 2021

Ah, yes, you're right about us only testing with Java 11.

There's a good chance we will drop Java 8 support very soon so no need to change the workflows.

@glefloch glefloch merged commit 1fe4ba7 into quarkusio:main Mar 31, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants