Allow skipping OIDC issuer verification #16324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsmet not sure it will be ready to be merged today but even it will be I'll ping you to confirm it is ok to do it - and certainly won't do it tomorrow :-) |
|
@pedroigor Hi Pedro - let me update the java docs/guides to warn stronger against skipping the issuer check |
sberyozkin
force-pushed
the
oidc_any_issuer
branch
from
486bb1c
to
6e761d9
Compare
|
@pedroigor Hi Pedro - I've added a dedicated section providing more information about the claim verification and |
pedroigor
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16294.
Fixes #16384.
This PR allows the users to skip the issuer verification by setting
quarkus.oidc.token.issuer=any. (it was a default for the bearer token verification in the earlier versions).Also did a few tiny optimizations to pre-calculate the issuer, audience early as opposed do it during every request.
Unfortunately I could not test as
InetAddress.getLocalAddresstakes ages unlesshostsis updated (I did try to optionally use the IP address in the Keycloak test module) but it is not realistic for CI.