Fix build issue when client and server RESTEasy Reactive jackson deps are used together #16368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are used together
|
@famod is there a way we have can have an enforcer rule that enforces that all classes that extend |
|
ArchUnit would be way more suitable for such things. |
|
But I don't see I way that such rules could apply to all modules, no? |
|
It's not totally trivial, but via surefire you can run tests from jars so you could define those rules in a central module and add executions to all modules that need to be checked (ideally only add it to a parent to cover as much as possible). |
|
Understood, thanks 👍 |
|
@geoand are you planning to do that? I think ArchUnit would be a valuable addition to the Quarkus QA. |
|
I don't have any immediate plans, no. But it's certainly something I'll keep in mind if no one else comes up with something in the meantime |
michalszynkiewicz
approved these changes
Apr 8, 2021
|
thanks @geoand ! |
|
YW! |
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Jan 18, 2023
After quarkusio#27203, we can customize the object mappers to be used by REST Client Reactive. However, because of quarkusio#16368, the implementation was never picked up when the resteasy reactive jackson extension is in place. I tried to remove the ResteasyReactiveJacksonProviderDefinedBuildItem build item and surprisingly everything kept working fine (I verified the test that was added as part of quarkusio#16368. Fix quarkusio#23979
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Jan 18, 2023
After quarkusio#27203, we can customize the object mappers to be used by REST Client Reactive. However, because of quarkusio#16368, the implementation was never picked up when the resteasy reactive jackson extension is in place. I tried to remove the ResteasyReactiveJacksonProviderDefinedBuildItem build item and surprisingly everything kept working fine (I verified the test that was added as part of quarkusio#16368. Fix quarkusio#23979
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Jan 18, 2023
After quarkusio#27203, we can customize the object mappers to be used by REST Client Reactive. However, because of quarkusio#16368, the implementation was never picked up when the resteasy reactive jackson extension is in place. I tried to remove the ResteasyReactiveJacksonProviderDefinedBuildItem build item and surprisingly everything kept working fine (I verified the test that was added as part of quarkusio#16368. Fix quarkusio#23979
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Jan 19, 2023
After quarkusio#27203, we can customize the object mappers to be used by REST Client Reactive. However, because of quarkusio#16368, the implementation was never picked up when the resteasy reactive jackson extension is in place. I tried to remove the ResteasyReactiveJacksonProviderDefinedBuildItem build item and surprisingly everything kept working fine (I verified the test that was added as part of quarkusio#16368. Fix quarkusio#23979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was originally reported here.