Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Service account also applied to RevisionSpec #16385

Merged
merged 1 commit into from Apr 9, 2021
Merged

Make Service account also applied to RevisionSpec #16385

merged 1 commit into from Apr 9, 2021

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Apr 9, 2021

Resolves: #16376

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 9, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/feat/fix/docs but be a proper sentence

This message is automatically generated by a bot.

@geoand geoand changed the title fix: Service account is also applied to RevisionSpec Make Service account also applied to RevisionSpec Apr 9, 2021
geoand
geoand approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 7a3c0b1 into quarkusio:main Apr 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 9, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.2.Final Apr 10, 2021
@gsmet
Copy link
Member

gsmet commented Apr 10, 2021

I wasn't able to backport this one as it depends on Dekorate 2. So either we need a specific PR or we backport the whole Dekorate 2 upgrade but I'm not really sure it's a good idea.

@gsmet gsmet modified the milestones: 1.13.2.Final, 2.0 - main Apr 10, 2021
@geoand
Copy link
Contributor

geoand commented Apr 10, 2021

I think a 1.13 specific PR would be best.

@iocanel can you do that please?

@iocanel
Copy link
Contributor Author

iocanel commented Apr 11, 2021

I think a 1.13 specific PR would be best.

@iocanel can you do that please?

With my morning coffee!

@geoand
Copy link
Contributor

geoand commented Apr 11, 2021

Thanks 👍

@iocanel iocanel mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.

Unable to obtain configuration for Secret objects from Kubernetes API Server in Funqy apps
3 participants
@iocanel @gsmet @geoand