Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Introduce COMMON_MAVEN_ARGS with --fail-at-end #16424

Merged
merged 1 commit into from Apr 11, 2021
Merged

CI: Introduce COMMON_MAVEN_ARGS with --fail-at-end #16424

merged 1 commit into from Apr 11, 2021

Conversation

famod
Copy link
Member

@famod famod commented Apr 11, 2021

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Apr 11, 2021
@famod famod requested a review from gsmet April 11, 2021 19:07
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 11, 2021
@quarkusio quarkusio deleted a comment from quarkus-bot bot Apr 11, 2021
@famod
Copy link
Member Author

famod commented Apr 11, 2021

Those Kafka failures are known flakes: #16371

Same for the aborted native messaging tests job: #16415
(Seems we have to set the timeout also for those jobs + probably for failsafe-plugin. Will check in the next days.)

TCKs failure looks very unrelated:

2021-04-11T17:42:31.7375043Z 2021-04-11 17:42:31,710 INFO  [io.quarkus] (main) Quarkus 999-SNAPSHOT on JVM started in 0.670s. Listening on: http://localhost:8081
2021-04-11T17:42:31.7376011Z 2021-04-11 17:42:31,711 INFO  [io.quarkus] (main) Profile test activated. 
2021-04-11T17:42:31.7378076Z 2021-04-11 17:42:31,711 INFO  [io.quarkus] (main) Installed features: [cdi, mutiny, smallrye-context-propagation, smallrye-fault-tolerance, smallrye-metrics]
2021-04-11T17:42:36.2182190Z 2021-04-11 17:42:36,068 INFO  [io.quarkus] (main) Quarkus stopped in 0.023s
2021-04-11T17:42:36.2383768Z [ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.331 s <<< FAILURE! - in org.eclipse.microprofile.fault.tolerance.tck.CircuitBreakerRetryTest
2021-04-11T17:42:36.2392955Z [ERROR] org.eclipse.microprofile.fault.tolerance.tck.CircuitBreakerRetryTest.testCircuitOpenWithMultiTimeoutsAsync  Time elapsed: 0.518 s  <<< FAILURE!
2021-04-11T17:42:36.2397567Z java.lang.AssertionError: serviceC should retry in testCircuitOpenWithMultiTimeouts on iteration 3
2021-04-11T17:42:36.2399147Z 	at org.testng.Assert.fail(Assert.java:96)
2021-04-11T17:42:36.2403940Z 	at org.eclipse.microprofile.fault.tolerance.tck.CircuitBreakerRetryTest.testCircuitOpenWithMultiTimeoutsAsync(CircuitBreakerRetryTest.java:487)

@gsmet
Copy link
Member

gsmet commented Apr 11, 2021

Yeah the timeout for failsafe is different so we would need to set both: failsafe.timeout.

Probably something we could add to the common args. It won't hurt anyway.

@famod
Copy link
Member Author

famod commented Apr 11, 2021

I think we should better add it to pom.xml (a base value in build-parent which is overridden in a few places, e.g. in the maven tests), reducing noise in the workflow file.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 11, 2021

Failing Jobs - Building a7712ad

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 8 Build Test failures Logs Raw logs

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka

io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - Source on GitHub

io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - Source on GitHub


⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - Source on GitHub

io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - Source on GitHub

@famod
Copy link
Member Author

famod commented Apr 11, 2021

Just known flakes, merging...

@famod famod merged commit 851ef0a into quarkusio:main Apr 11, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 11, 2021
@famod famod deleted the fail-at-end branch April 11, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants