Add a small note about Kubernetes Client configuration properties. #16593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
machi1990
reviewed
Apr 16, 2021
geoand
changed the title
geoand
reviewed
Apr 17, 2021
| @@ -680,6 +680,20 @@ quarkus.kubernetes.readiness-probe.period=45s | |||
| In this example `initial-delay` and `period` are fields of the type `Probe`. | |||
| Below you will find tables describing all available types. | |||
|
|
|||
| ==== Client Connection Configuration | |||
| The underline Kubernetes client connection can be configured through properties defined by the Kubernetes Client runtime. | |||
There was a problem hiding this comment.
Underlying? Same for latter on in the text as well
There was a problem hiding this comment.
I would say something like:
You may need to configure the connection to your Kubernetes cluster.
By default, it automatically uses the active _context_ used by `kubectl`.
...
geoand
reviewed
Apr 17, 2021
cescoffier
requested changes
Apr 19, 2021
| @@ -680,6 +680,20 @@ quarkus.kubernetes.readiness-probe.period=45s | |||
| In this example `initial-delay` and `period` are fields of the type `Probe`. | |||
| Below you will find tables describing all available types. | |||
|
|
|||
| ==== Client Connection Configuration | |||
| The underline Kubernetes client connection can be configured through properties defined by the Kubernetes Client runtime. | |||
There was a problem hiding this comment.
I would say something like:
You may need to configure the connection to your Kubernetes cluster.
By default, it automatically uses the active _context_ used by `kubectl`.
...
|
When you are done, please squash the commits. Thanks! |
rafaeltuelho
force-pushed
the
doc-patch-1
branch
from
ff4b5b8
to
e4d7c40
Compare
Done! |
geoand
approved these changes
Apr 19, 2021
cescoffier
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small doc PR based on this thread https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/openshift-extension/near/234538945