Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default file log level in logging guide #1660

Merged
merged 1 commit into from Mar 28, 2019
Merged

Fix default file log level in logging guide #1660

merged 1 commit into from Mar 28, 2019

Conversation

xstefank
Copy link
Contributor

According to [1] it should be ALL.

[1] https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/logging/FileConfig.java#L43

Not sure if issue is needed. If so, I will create one and update this PR.

@gsmet
Copy link
Member

gsmet commented Mar 28, 2019

@dmlloyd could you take a look at this one?

Is the default really supposed to be ALL? It doesn't seem right.

Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is ALL because normally the file handler will log everything that is enabled by category (the default for most categories is INFO or WARN). Otherwise, if you enable DEBUG or TRACE for some category, you won't see them output anywhere.

The console OTOH is normally set at INFO because having a flood of output on the console is not normally useful.

@dmlloyd dmlloyd merged commit 66f1459 into quarkusio:master Mar 28, 2019
@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants