Refactoring of the MavenProjectBuildFile to make it usable by the CLI #16629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MavenParojectBuildFile is refactored and moved to the devtools common so that it can be used by the CLI. The implementation is backed by the artifact descriptor result.
NOTE: there is a change in listing extensions. The CLI was based on the raw (i.e. incomplete)
Model
, so it was listing only the extensions present in the pom that would be direct extension dependencies (which, btw, might not be the complete list if the module had a parent that had other extension dependencies). The Maven plugin (as well as the Gradle one) would actually list not only the direct dependencies but also the transitive extension dependencies. However, collecting transitive dependencies takes time, specifically, it takes ~300ms more than collecting the direct dependencies only. So, for now, I kept the current CLI listing (i.e. the direct deps only) for both the CLI and the Maven plugin.Fixes #16352