Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the MavenProjectBuildFile to make it usable by the CLI #16629

Merged
merged 1 commit into from Apr 20, 2021

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Apr 19, 2021

MavenParojectBuildFile is refactored and moved to the devtools common so that it can be used by the CLI. The implementation is backed by the artifact descriptor result.

NOTE: there is a change in listing extensions. The CLI was based on the raw (i.e. incomplete) Model, so it was listing only the extensions present in the pom that would be direct extension dependencies (which, btw, might not be the complete list if the module had a parent that had other extension dependencies). The Maven plugin (as well as the Gradle one) would actually list not only the direct dependencies but also the transitive extension dependencies. However, collecting transitive dependencies takes time, specifically, it takes ~300ms more than collecting the direct dependencies only. So, for now, I kept the current CLI listing (i.e. the direct deps only) for both the CLI and the Maven plugin.

Fixes #16352

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/testing labels Apr 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c986863

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 15
Maven Tests - JDK 11 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.AddExtensionMojoTest.testAddMultipleDependency line 133 - More details - Source on GitHub

io.quarkus.maven.AddExtensionMojoTest.testAddSingleDependency line 119 - More details - Source on GitHub

io.quarkus.maven.AddExtensionsMojoTest.testAddMultipleDependency - More details - Source on GitHub

io.quarkus.maven.AddExtensionsMojoTest.testAddSingleDependency - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.AddExtensionMojoTest.testAddMultipleDependency line 133 - More details - Source on GitHub

io.quarkus.maven.AddExtensionMojoTest.testAddSingleDependency line 119 - More details - Source on GitHub

io.quarkus.maven.AddExtensionsMojoTest.testAddMultipleDependency - More details - Source on GitHub

io.quarkus.maven.AddExtensionsMojoTest.testAddSingleDependency - More details - Source on GitHub

common so that it can be used by the CLI. The implementation is backed
by the artifact descriptor.
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2021

Failing Jobs - Building ca0ff4c

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

io.quarkus.jaxrs.client.reactive.deployment.test.UniInvokerTestCase.testInjection line 48 - More details - Source on GitHub

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@aloubyansky aloubyansky merged commit 9ebe9f8 into quarkusio:main Apr 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qs add some-ext broken always adding bom
2 participants