Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Request has already been read" in Dev UI LogStream #16648

Merged
merged 1 commit into from Apr 20, 2021
Merged

Fix "Request has already been read" in Dev UI LogStream #16648

merged 1 commit into from Apr 20, 2021

Conversation

phillip-kruger
Copy link
Member

Fix #16537

Signed-off-by:Phillip Kruger phillip.kruger@gmail.com

Signed-off-by:Phillip Kruger <phillip.kruger@gmail.com>
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks OK, but any idea why we get websocket upgrade requests that are already ended?

@phillip-kruger
Copy link
Member Author

Not sure, I could only recreate it when I refresh my browser very fast continually, so maybe a timing issue... ? I have no idea what I am talking about :)

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 20, 2021
@FroMage
Copy link
Member

FroMage commented Apr 20, 2021

Haha. Oh well, it's certainly not a step in the wrong direction, so 🤷 :)

@phillip-kruger phillip-kruger merged commit 6c00972 into quarkusio:main Apr 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 20, 2021
@phillip-kruger phillip-kruger deleted the dev-ui-logstream-fix branch April 20, 2021 14:27
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev UI: exception related to log streaming
3 participants