Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate io.netty.versions.properties instead of ignoring them #16664

Merged
merged 4 commits into from Apr 21, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 20, 2021

Fixes #16662

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a690a9b

Status Name Step Test failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

@geoand
Copy link
Contributor

geoand commented Apr 21, 2021

Could we introduce an enhancement in the Maven uberjar test, that ensures that calls the Netty class mentioned in the issue?

The comment says we only log ignored entries grouped if they are classes
but that's not true, we log them all. So we should remove this
duplicated warning.
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021

Failing Jobs - Building 524a9fd

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 58 - More details - Source on GitHub

@gsmet
Copy link
Member Author

gsmet commented Apr 21, 2021

@stuartwdouglas the build failure above looks suspicious.

@gsmet gsmet merged commit 9861d4f into quarkusio:main Apr 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 21, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 2.0.0.Alpha1 Apr 21, 2021
@stuartwdouglas
Copy link
Member

I am looking into it. It looks like somehow an additional test run is triggered after a single change.

@stuartwdouglas
Copy link
Member

It's because of this:

Files.setLastModifiedTime(path, FileTime.fromMillis(System.currentTimeMillis()));

Updating the file timestamp can result in a race where the test polling timer sees two changes, and runs the tests a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.netty.util.Version#identify not working in uber-jars
3 participants