Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make providers registered with @RegisterProvider CDI beans in reactive rest client #16673

Merged
merged 1 commit into from Apr 21, 2021
Merged

Make providers registered with @RegisterProvider CDI beans in reactive rest client #16673

merged 1 commit into from Apr 21, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 21, 2021

Fixes: #16540

@geoand geoand mentioned this pull request Apr 21, 2021
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ef9c1b4

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
✖ Native Tests - Read JSON matrix ⚠️ Check → Logs Raw logs
🚫 Native Tests - Windows - ${{ matrix.category }}

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 4b58fa8

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

michalszynkiewicz
michalszynkiewicz approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@michalszynkiewicz michalszynkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@michalszynkiewicz michalszynkiewicz added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 21, 2021
@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021

YW!

@geoand geoand merged commit 86af58d into quarkusio:main Apr 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 21, 2021
@geoand geoand deleted the #16540 branch April 21, 2021 13:11
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 21, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 2.0.0.Alpha1 Apr 21, 2021
@gsmet
Copy link
Member

gsmet commented Apr 26, 2021

Same here, this will have to wait or will require a specific patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.

Injecting into custom ClientRequestFilter does not work with Reactive RestClient
3 participants
@geoand @gsmet @michalszynkiewicz