Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka-client : missing substituted JmxReporter method #16766

Merged
merged 1 commit into from Apr 26, 2021
Merged

kafka-client : missing substituted JmxReporter method #16766

merged 1 commit into from Apr 26, 2021

Conversation

glandais-sparklane
Copy link
Contributor

Fix #16765 kafka-client : Detected a MBean server in the image heap

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 23, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

cescoffier
cescoffier approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. That method was introduced in 2.6. It's weird we didn't catch the issue on CI.

I wonder if we should not delete the JMXReporting completely and cleanup the accessors. Anyway, if that fixes the issues, it's ok.

@cescoffier cescoffier merged commit 6b82625 into quarkusio:main Apr 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 26, 2021
@glandais-sparklane glandais-sparklane deleted the fix/issue-16765 branch April 26, 2021 06:48
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.3.Final Apr 26, 2021
@gsmet gsmet modified the milestones: 1.13.3.Final, 1.11.7.Final Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/kafka
Projects
None yet
Milestone
1.11.7.Final
Development

Successfully merging this pull request may close these issues.

kafka-client : Detected a MBean server in the image heap
3 participants
@glandais-sparklane @cescoffier @gsmet