Use the watch service when possible #16962

stuartwdouglas · 2021-05-04T01:44:55Z

Using the watch service on Linux allows for
tests to run instantly after the file is saved.

Other platforms don't have a useful watch service
implementation, so we still use polling for these
platforms.

quarkus-bot · 2021-05-04T03:32:28Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b1b1af9`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 15	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 79 - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 55 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 core/deployment

✖ io.quarkus.deployment.dev.FileSystemWatcherTestCase.testFileSystemWatcher line 43 - More details - Source on GitHub

⚙️ JVM Tests - JDK 15 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 77 - More details - Source on GitHub

core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java

quarkus-bot · 2021-05-04T06:35:30Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `3775146`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Linux	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 15	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Amazon	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Cache		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data4	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging2	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2	`Reclaim Disk Space`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security3	`Reclaim Disk Space`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 53 - More details - Source on GitHub

quarkus-bot · 2021-05-04T09:43:45Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `94aa0de`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 65 - More details - Source on GitHub

gastaldi · 2021-05-04T14:19:33Z

core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java

-                    public void run() {
-                        periodicTestCompile();
+            if (testClassChangeWatcher == null && testClassChangeTimer == null) {
+                if (IS_LINUX) {


I'm almost sure that the WatchService also works in Windows and Mac OSX. What's the reason for not using on other OSes?

On mac it is just a polling based impl, that polls much slower than our current version (or at least it was when I last used it). Not sure on windows, I need to check, but I thought I would start with Linux as I know it works.

gsmet · 2021-05-04T15:27:10Z

@stuartwdouglas I'm not sure if the test failure could be related?

quarkus-bot · 2021-05-10T06:30:30Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `3f18388`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Linux	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 66 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 53 - More details - Source on GitHub

stuartwdouglas · 2021-05-10T07:18:33Z

I have hopefully added a guard that will stop the failures.

quarkus-bot · 2021-05-10T09:52:20Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `d8fa7d0`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Linux	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 58 - More details - Source on GitHub

Using the watch service on Linux allows for tests to run instantly after the file is saved. Other platforms don't have a useful watch service implementation, so we still use polling for these platforms.

stuartwdouglas · 2021-05-11T07:25:57Z

This should be good to go now.

gsmet

OK, let's get this in!

quarkus-bot bot added the area/core label May 4, 2021

stuartwdouglas added the area/continuous-testing label May 4, 2021

stuartwdouglas force-pushed the watch-service-testing branch from b1b1af9 to 3775146 Compare May 4, 2021 05:49

gastaldi reviewed May 4, 2021

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java Show resolved Hide resolved

stuartwdouglas force-pushed the watch-service-testing branch from 3775146 to 94aa0de Compare May 4, 2021 06:32

gastaldi reviewed May 4, 2021

View reviewed changes

stuartwdouglas force-pushed the watch-service-testing branch 2 times, most recently from 3f18388 to d8fa7d0 Compare May 10, 2021 06:26

quarkus-bot bot added the area/testing label May 10, 2021

Use the watch service when possible

de4cf75

Using the watch service on Linux allows for tests to run instantly after the file is saved. Other platforms don't have a useful watch service implementation, so we still use polling for these platforms.

stuartwdouglas force-pushed the watch-service-testing branch from d8fa7d0 to de4cf75 Compare May 11, 2021 03:34

gsmet approved these changes May 11, 2021

View reviewed changes

gsmet merged commit 25a7c5e into quarkusio:main May 11, 2021

quarkus-bot bot added this to the 2.0 - main milestone May 11, 2021

Use the watch service when possible #16962

Use the watch service when possible #16962

Conversation

stuartwdouglas commented May 4, 2021

quarkus-bot bot commented May 4, 2021 • edited

Failing Jobs - Building b1b1af9

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 core/deployment

⚙️ JVM Tests - JDK 15 #

📦 extensions/vertx-http/deployment

quarkus-bot bot commented May 4, 2021 • edited

Failing Jobs - Building 3775146

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

quarkus-bot bot commented May 4, 2021 • edited

Failing Jobs - Building 94aa0de

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

gastaldi May 4, 2021

Choose a reason for hiding this comment

stuartwdouglas May 4, 2021

Choose a reason for hiding this comment

gsmet commented May 4, 2021

quarkus-bot bot commented May 10, 2021 • edited

Failing Jobs - Building 3f18388

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

stuartwdouglas commented May 10, 2021

quarkus-bot bot commented May 10, 2021 • edited

Failing Jobs - Building d8fa7d0

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

stuartwdouglas commented May 11, 2021

gsmet left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented May 4, 2021 •

edited

Failing Jobs - Building `b1b1af9`

quarkus-bot bot commented May 4, 2021 •

edited

Failing Jobs - Building `3775146`

quarkus-bot bot commented May 4, 2021 •

edited

Failing Jobs - Building `94aa0de`

quarkus-bot bot commented May 10, 2021 •

edited

Failing Jobs - Building `3f18388`

quarkus-bot bot commented May 10, 2021 •

edited

Failing Jobs - Building `d8fa7d0`