Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the JavaDoc in io.quarkus.arc.processor.QualifierRegistrar #16971

Merged
merged 1 commit into from May 7, 2021

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented May 4, 2021

No description provided.

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 4, 2021
@machi1990 machi1990 requested a review from mkouba May 4, 2021 12:47
@quarkus-bot
Copy link

quarkus-bot bot commented May 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4f4dd16

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.PausedMethodTest.testSchedulerPauseMethod line 40 - More details - Source on GitHub

@ppalaga ppalaga force-pushed the 210504-javadoc-QualifierRegistrar branch from 4f4dd16 to dd58052 Compare May 4, 2021 15:35
@ppalaga
Copy link
Contributor Author

ppalaga commented May 4, 2021

dd58052: addressed the comment of @mkouba

@quarkus-bot
Copy link

quarkus-bot bot commented May 4, 2021

Failing Jobs - Building dd58052

Status Name Step Test failures Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate line 46 - More details - Source on GitHub

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gsmet gsmet merged commit 5551461 into quarkusio:main May 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants