Reduce 20 mins grace period in DevModeTestUtils to 3 mins #16983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we sure that this is no longer a problem? The original issue was that mvn quarkus:dev could download extra dependencies. Maybe these tests should be run in offline mode to make sure that they are not downloading anything as part of the test run. |
|
I do agree that the 20m is super annoying, I have been bitten by it before. |
I can only speak for myself and TBH I'm not 100% sure. But I think better reduce it to a more bearable value and see how it goes?
This is an interesting proposal! I'll put it on my list (unless someone else wants to try it out). |
stuartwdouglas
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced 2 years ago by @Sanne and whatever was the reason for such a generous grace period back then, today it shouldn't be necessary anymore and it even conflicts with surefire timeout of 10 mins we have in some places now.
(and it can be annoying locally when you scan for failures in multiple tests of a module, e.g. on JDK 16)