Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated QuarkusTestBeforeAllCallback #17027

Conversation

aloubyansky
Copy link
Member

The interface was deprecated about 8 months ago in 2515e95

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8b423a7

Status Name Step Test failures Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/elytron-undertow

io.quarkus.it.undertow.elytron.BaseAuthRestTest.testPost line 28 - More details - Source on GitHub

@aloubyansky aloubyansky force-pushed the remove-deprecated-quarkustestbeforeallcallback branch from 8b423a7 to 36b6799 Compare May 6, 2021 07:06
@famod
Copy link
Member

famod commented May 6, 2021

Btw, how are all those removals going to be communicated? Via the "breaking-change" label?
Or will there only be a general hint like "In 2.0 we removed stuff that was already deprecated."?

/cc @gsmet

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 6, 2021
@gsmet
Copy link
Member

gsmet commented May 6, 2021

It might be good to document them. Everything we removed was pretty low level though.

@gsmet gsmet merged commit 7afd42e into quarkusio:main May 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 6, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants