CI: workflow unifications to reduce noise, run_jvm flag for jvm-tests #17166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/gradle
famod
commented
May 12, 2021
| # Skip main in forks | ||
| if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')" | ||
| needs: build-jdk11 | ||
| if: "needs.calculate-test-jobs.outputs.run_jvm == 'true' && (github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main'))" | ||
| timeout-minutes: 240 |
There was a problem hiding this comment.
Note: This was 180 for the windows job. It didn't feel important enough to add it to the matrix. 🤷
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main part: Windows jobs are now part of the existing matrix jobs, increasing cohesion and reducing noise.
Please let me know if you want me to squash some commits.
This was also a good opportunity to add a "run flag" for the jvm tests (now consistent with the other test jobs).