Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quarkus-extension.yaml #17218

Merged
merged 1 commit into from May 14, 2021

Conversation

stuartwdouglas
Copy link
Member

This avoids problems with the IDE overwriting changes
made by the bootstrap plugin.

This avoids problems with the IDE overwriting changes
made by the bootstrap plugin.
@quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2021

@Sanne Sanne merged commit 3baee43 into quarkusio:main May 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 14, 2021
@gsmet
Copy link
Member

gsmet commented May 17, 2021

@aloubyansky @ia3andy I think this requires further discussion. If it's a problem, shouldn't we change this to be the default when creating a new extension?

But that wouldn't be very handy to not have the yaml extension for the file that is maintained by the developer.

@ia3andy
Copy link
Contributor

ia3andy commented May 17, 2021

I agree with @gsmet:

  • we would need to update the templates for new extensions
  • keeping .yaml extension would be better(but maybe it's what making the IDE overwrite it?)

@Sanne
Copy link
Member

Sanne commented May 17, 2021

I think this requires further discussion

see the mailing list [quarkus-dev] quarkus-extension.yaml vs QuarkusDevModeTest, and follow up pr #17270

@ia3andy
Copy link
Contributor

ia3andy commented May 17, 2021

We also need to update the Quarkiverse extensions?

@ia3andy
Copy link
Contributor

ia3andy commented May 17, 2021

@Sanne I think it was a bit to rushy to merge this PR (even more with @gsmet and me saying we wanted a quick discussion to be sure there weren't better and more transparent alternatives). We come from a long WE and didn't have time to really look at the thread. Renaming all those have consequences outside of quarkus-core.

Also, I think @aloubyansky said in the thread that he would prefer something else..

@aloubyansky
Copy link
Member

We also need to update the Quarkiverse extensions?

If it affects them. AFAIU, it breaks only when the QuarkusDevModeTest tests are launched from IDEA.

@ia3andy
Copy link
Contributor

ia3andy commented May 17, 2021

Ok my bad @Sanne , I missed the part were the old format was still compatible.. so with the following up PR from @aloubyansky we are alright!

@Sanne
Copy link
Member

Sanne commented May 17, 2021

@ia3andy no problem at all :) but also I merely am the mindless bot who pressed the "merge" button: it was already approved and reviewed and CI flagged it as green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment