Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute type-safe validation - various fixes #17313

Merged
merged 1 commit into from May 18, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 18, 2021

  • fix NPE when a loop element hint refers to a literal value
  • put bindings for iteration metadata inside a loop section; previously
    iteration metadata expressions together with type-safe templates caused
    a build failure by default

- fix NPE when a loop element hint refers to a literal value
- put bindings for iteration metadata inside a loop section; previously
iteration metadata expressions together with type-safe templates caused
a build failure by default
@mkouba mkouba requested a review from gastaldi May 18, 2021 09:22
@quarkus-bot quarkus-bot bot added the area/qute The template engine label May 18, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit d1e6ed6 into quarkusio:main May 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants