gRPC treating clients without configuration as self-calling #17338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalszynkiewicz
requested review from
mkouba and
cescoffier
and removed request for
mkouba
mkouba
reviewed
May 19, 2021
| @@ -30,7 +30,7 @@ | |||
| */ | |||
| String value() default ELEMENT_NAME; | |||
|
|
|||
| public final class Literal extends AnnotationLiteral<GrpcClient> implements GrpcClient { | |||
| final class Literal extends AnnotationLiteral<GrpcClient> implements GrpcClient { | |||
There was a problem hiding this comment.
everything is public in an interface anyway
There was a problem hiding this comment.
Ah, I didn't know it works like this for annotations as well.
|
It should work with Native may not work though, I'm not sure if we enable test profile when running a native executable. |
cescoffier
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, gRPC testing experience is worse than REST. A user has to know the port of the gRPC server in tests, and has to configure a client stub for tests in application.properties.
This PR proposes allowing injection of client stubs without config when running in test mode. Such clients are automatically configured to call the exposed gRPC server.
The drawback of this change is that misconfiguration problems may be a bit more difficult to spot in tests.
@cescoffier @mkouba WDYT?