Register ConfigSources directly with the builder #17483

radcortez · 2021-05-26T17:19:15Z

The idea here is to register sources directly with the SmallRyeConfigBuilder instead of relying on the ServiceLoader. One of the main motivations is to better control what we add to Config, avoid adding problematic sources and avoid discovery at runtime.

One other issue is related with #5492. Even with the guard added by

quarkus/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigBuildSteps.java

Lines 96 to 98 in a9d9a69

    
           final List<String> list = names.stream() 
        
                   // todo: see https://github.com/quarkusio/quarkus/issues/5492 
        
                   .filter(s -> !s.startsWith("org.jboss.resteasy.microprofile.config.")).collect(Collectors.toList());

Graal is still able to reach the source entries but fails because they are not registered for reflection. Check smallrye/smallrye-config#580 and https://groups.google.com/g/quarkus-dev/c/yP7QsNRgYxY

The PR adds a check if servlet APIs and implementations are available to either include the RESTEasy config sources or rewrite them to not use their servlet-based implementation. Ideally, the RESTEasy config sources should be fixed.

It also adds the @StaticInitSafe annotation to mark sources that can be safely added and started during static init.

quarkus-bot · 2021-05-27T18:14:45Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `7634509`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16
✖	Maven Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Data3	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data4	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - HTTP	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Messaging1	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Messaging2	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Misc1	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Misc2	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Misc3	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Security1	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Security2	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/grpc-streaming

✖ io.quarkus.grpc.example.streaming.StreamingEndpointTest.testPipe line 30 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

⚙️ Native Tests - Data4 #

📦 integration-tests/neo4j

✖ io.quarkus.it.neo4j.Neo4jFunctionalityInGraalITCase.testBlockingNeo4jFunctionality - More details - Source on GitHub

⚙️ Native Tests - HTTP #

📦 integration-tests/elytron-resteasy

✖ io.quarkus.it.resteasy.elytron.BaseAuthIT.testGet - More details - Source on GitHub

⚙️ Native Tests - Messaging1 #

📦 integration-tests/kafka-avro-apicurio2

✖ io.quarkus.it.kafka.KafkaAvroIT.testApicurioAvroProducer - More details - Source on GitHub

📦 integration-tests/kafka-avro

✖ io.quarkus.it.kafka.KafkaAvroIT.testApicurioAvroProducer - More details - Source on GitHub

📦 integration-tests/kafka-sasl

✖ io.quarkus.it.kafka.SaslKafkaConsumerIT.testReception - More details - Source on GitHub

📦 integration-tests/kafka-snappy

✖ io.quarkus.it.kafka.KafkaSnappyCodecITCase.testJacksonCodec - More details - Source on GitHub

📦 integration-tests/kafka-ssl

✖ io.quarkus.it.kafka.SslKafkaConsumerITCase.testReception - More details - Source on GitHub

📦 integration-tests/kafka-streams

✖ io.quarkus.it.kafka.streams.KafkaStreamsITCase.testKafkaStreams - More details - Source on GitHub

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.KafkaConsumerITCase.test - More details - Source on GitHub

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorIT.test - More details - Source on GitHub

⚙️ Native Tests - Messaging2 #

📦 integration-tests/reactive-messaging-amqp

✖ io.quarkus.it.amqp.AmqpConnectorIT.test - More details - Source on GitHub

⚙️ Native Tests - Misc1 #

📦 integration-tests/jgit

✖ io.quarkus.it.jgit.NativeJGitIT.shouldClone - More details - Source on GitHub

⚙️ Native Tests - Misc2 #

📦 integration-tests/mailer

✖ io.quarkus.it.mailer.MailerIT.sendHtmlEmail - More details - Source on GitHub

⚙️ Native Tests - Misc3 #

📦 integration-tests/smallrye-graphql-client

✖ io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testTypesafeClient - More details - Source on GitHub

⚙️ Native Tests - Security1 #

📦 integration-tests/elytron-security-jdbc

✖ io.quarkus.elytron.security.jdbc.it.ElytronSecurityJdbcIT.anonymous - More details - Source on GitHub

📦 integration-tests/elytron-security-ldap

✖ io.quarkus.elytron.security.ldap.it.ElytronSecurityLdapIT.anonymous - More details - Source on GitHub

📦 integration-tests/elytron-security-oauth2

✖ io.quarkus.it.elytron.oauth2.ElytronOauth2ExtensionResourceITCase.anonymous - More details - Source on GitHub

📦 integration-tests/elytron-security

✖ io.quarkus.it.elytron.JCAITCase.testDecodeRSAKey - More details - Source on GitHub

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testAccessAdminResourceCustomHeaderNoBearerScheme - More details - Source on GitHub

quarkus-bot · 2021-05-31T17:28:19Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `39ce031`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs
✖	Maven Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Main	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSTestCase.testGzipConfig line 222 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSTestCase.testGzipConfig line 222 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSTestCase.testGzipConfig line 222 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

⚙️ Native Tests - Main #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSITCase.testGzipConfig - More details - Source on GitHub

quarkus-bot · 2021-06-02T13:49:30Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `9ee4749`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Native Tests - Cache	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data1	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data2	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data3	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data4	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data5	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data6	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data7	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - HTTP	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Messaging2	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc1	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Misc2	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc3	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc4	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security1	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security2	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security3	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Spring	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Windows - hibernate-validator	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - gRPC	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - Misc1 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.NativeImageIT.testJavaLibraryPathAtRuntime - More details - Source on GitHub

quarkus-bot · 2021-06-22T18:22:56Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a8e18aa`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Native Tests - Main	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - Main #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSITCase.testGzipConfig - More details - Source on GitHub

gsmet · 2021-06-28T09:11:35Z

@radcortez I rebased the PR but the failure in io.quarkus.it.main.JaxRSITCase.testGzipConfig looks a bit suspicious given it could be config-related.

radcortez · 2021-06-28T09:54:16Z

Sure, let me check.

quarkus-bot · 2021-06-28T13:41:02Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `e675c46`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Native Tests - Main	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - Main #

📦 integration-tests/main

✖ io.quarkus.it.main.JaxRSITCase.testGzipConfig - More details - Source on GitHub

quarkus-bot · 2021-07-08T23:10:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `6ad8efd`

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-rest-client

✖ io.quarkus.it.rest.client.BasicTest.shouldMakeJsonRequest line 40 - More details - Source on GitHub

geoand · 2021-07-09T14:44:02Z

Interesting!

I'll take a look on Monday

radcortez · 2021-07-09T14:57:24Z

Thanks! This also includes the work we talked about with the safe static init sources.

geoand

Great work!

I added a few comments

core/runtime/src/main/java/io/quarkus/runtime/configuration/StaticInitSafe.java

...t/src/main/java/io/quarkus/deployment/builditem/StaticInitConfigSourceProviderBuildItem.java

...loyment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java

docs/src/main/asciidoc/writing-extensions.adoc

geoand

Awesome, thanks!

quarkus-bot · 2021-07-12T20:45:20Z

Failing Jobs - Building `d6aee25`

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 16

quarkus-bot bot added area/config area/core labels May 26, 2021

radcortez mentioned this pull request May 26, 2021

Application fails to start in native image mode when some config sour… smallrye/smallrye-config#581

Closed

radcortez force-pushed the sources-with-builder branch from 66e10d7 to 7634509 Compare May 27, 2021 14:49

radcortez force-pushed the sources-with-builder branch from 7634509 to 39ce031 Compare May 31, 2021 13:57

radcortez force-pushed the sources-with-builder branch 2 times, most recently from 7f46266 to 9ee4749 Compare June 2, 2021 10:43

radcortez force-pushed the sources-with-builder branch from 9ee4749 to a8e18aa Compare June 22, 2021 14:58

gsmet force-pushed the sources-with-builder branch from a8e18aa to e675c46 Compare June 28, 2021 09:11

radcortez force-pushed the sources-with-builder branch from e675c46 to 860affb Compare June 29, 2021 14:31

quarkus-bot bot added area/smallrye area/tracing labels Jun 29, 2021

radcortez force-pushed the sources-with-builder branch from 860affb to 6ad8efd Compare July 8, 2021 19:14

quarkus-bot bot added the area/documentation label Jul 8, 2021

radcortez force-pushed the sources-with-builder branch from 6ad8efd to c474c5e Compare July 9, 2021 11:01

radcortez requested a review from geoand July 9, 2021 14:28

geoand reviewed Jul 12, 2021

View reviewed changes

Register ConfigSources directly with the builder

d6aee25

radcortez force-pushed the sources-with-builder branch from c474c5e to d6aee25 Compare July 12, 2021 15:48

radcortez requested a review from geoand July 12, 2021 15:48

geoand approved these changes Jul 12, 2021

View reviewed changes

radcortez mentioned this pull request Jul 13, 2021

Ensure YAML configuration is taken into account for DynamicFeatures #18238

Merged

gsmet merged commit 7c66d18 into quarkusio:main Jul 13, 2021

quarkus-bot bot added this to the 2.1 - main milestone Jul 13, 2021

This was referenced Jul 13, 2021

Register @ConfigMappings directly into the Config builder #18497

Merged

Move @StaticInitSafe annotation to the proper package #18755

Merged

radcortez mentioned this pull request Jul 23, 2021

Application fails to start in native image mode when some config sources are not available due to dead code elimination smallrye/smallrye-config#580

Closed

radcortez mentioned this pull request Sep 13, 2021

Register @ConfigMappings directly into the Config builder #20103

Merged

radcortez deleted the sources-with-builder branch November 22, 2021 21:56

	final List<String> list = names.stream()
	// todo: see https://github.com/quarkusio/quarkus/issues/5492
	.filter(s -> !s.startsWith("org.jboss.resteasy.microprofile.config.")).collect(Collectors.toList());

Register ConfigSources directly with the builder #17483

Register ConfigSources directly with the builder #17483

Conversation

radcortez commented May 26, 2021 • edited

quarkus-bot bot commented May 27, 2021 • edited

Failing Jobs - Building 7634509

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/grpc-streaming

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

⚙️ Native Tests - Data4 #

📦 integration-tests/neo4j

⚙️ Native Tests - HTTP #

📦 integration-tests/elytron-resteasy

⚙️ Native Tests - Messaging1 #

📦 integration-tests/kafka-avro-apicurio2

📦 integration-tests/kafka-avro

📦 integration-tests/kafka-sasl

📦 integration-tests/kafka-snappy

📦 integration-tests/kafka-ssl

📦 integration-tests/kafka-streams

📦 integration-tests/kafka

📦 integration-tests/reactive-messaging-kafka

⚙️ Native Tests - Messaging2 #

📦 integration-tests/reactive-messaging-amqp

⚙️ Native Tests - Misc1 #

📦 integration-tests/jgit

⚙️ Native Tests - Misc2 #

📦 integration-tests/mailer

⚙️ Native Tests - Misc3 #

📦 integration-tests/smallrye-graphql-client

⚙️ Native Tests - Security1 #

📦 integration-tests/elytron-security-jdbc

📦 integration-tests/elytron-security-ldap

📦 integration-tests/elytron-security-oauth2

📦 integration-tests/elytron-security

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc

quarkus-bot bot commented May 31, 2021 • edited

Failing Jobs - Building 39ce031

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/main

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/main

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/main

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

⚙️ Native Tests - Main #

📦 integration-tests/main

quarkus-bot bot commented Jun 2, 2021 • edited

Failing Jobs - Building 9ee4749

Test Failures

⚙️ Native Tests - Misc1 #

📦 integration-tests/maven

quarkus-bot bot commented Jun 22, 2021 • edited

Failing Jobs - Building a8e18aa

Test Failures

⚙️ Native Tests - Main #

📦 integration-tests/main

gsmet commented Jun 28, 2021

radcortez commented Jun 28, 2021

quarkus-bot bot commented Jun 28, 2021 • edited

Failing Jobs - Building e675c46

Test Failures

⚙️ Native Tests - Main #

📦 integration-tests/main

quarkus-bot bot commented Jul 8, 2021 • edited

Failing Jobs - Building 6ad8efd

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-rest-client

geoand commented Jul 9, 2021

radcortez commented Jul 9, 2021

geoand left a comment

Choose a reason for hiding this comment

geoand left a comment

Choose a reason for hiding this comment

radcortez commented May 26, 2021 •

edited

quarkus-bot bot commented May 27, 2021 •

edited

Failing Jobs - Building `7634509`

quarkus-bot bot commented May 31, 2021 •

edited

Failing Jobs - Building `39ce031`

quarkus-bot bot commented Jun 2, 2021 •

edited

Failing Jobs - Building `9ee4749`

quarkus-bot bot commented Jun 22, 2021 •

edited

Failing Jobs - Building `a8e18aa`

quarkus-bot bot commented Jun 28, 2021 •

edited

Failing Jobs - Building `e675c46`

quarkus-bot bot commented Jul 8, 2021 •

edited

Failing Jobs - Building `6ad8efd`

Failing Jobs - Building `d6aee25`