-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the maven build task compatible with parallel builds #17484
Conversation
b015f29
to
7f5079a
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building b015f29
Full information is available in the Build summary check run. Test Failures⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖ |
7f5079a
to
4f6dc1d
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 4f6dc1d
Full information is available in the Build summary check run. Test Failures⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ ⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖ |
4f6dc1d
to
bde60d4
Compare
case TEST: | ||
return TEST; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as it is actually dead code
@aloubyansky @famod Hi, WDYT of this PR? It is the best compromise I could find as it does the job and it doesn't brake anything. To be honest, I'm not really fan of relying on the runtime default profile, I would rather prefer having a specific static field for that but if I do so I break the test |
core/deployment/src/main/java/io/quarkus/runner/bootstrap/AugmentActionImpl.java
Show resolved
Hide resolved
bde60d4
to
c44cdc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @essobedo Thanks!
FYI I don't believe that this PR is the root cause of the build failure since it is an IT of Gradle in native mode and this PR doesn't affect the Gradle related code. |
@aloubyansky Could you please relaunch the build if needed? |
@aloubyansky WDYT about backporting (to 2.0)? |
Let me know if you want a back port, I can provide it. |
BTW I did not forget to provide some doc about what has been done at maven plugin level, it will be my next contribution. I need to finish something else first |
Currently, this would merge just fine to the 2.0 branch. But thanks for your offer!
Yes, see the milestone assignment (top right). |
fixes #16932
Motivation
So far, due to the fact that System properties can be set by the build task of the maven plugin, we could end up with build conflicts when used in parallel mode. The goal of this enhancement is to ensure that we can use parallel builds without getting conflicts.
Modifications
ProfileManager
is loaded with differentQuarkusClassLoader
s