Safer annotations removal #17503
Merged
Safer annotations removal #17503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e injection" This reverts commit 5e4e822.
|
I think there's something wrong here. The Files changed tab doesn't show anything. As far as I can see you reverted a commit then reverted the revert :). I'm pretty sure we need something more than just this revert to disable the feature so I suppose it should have been another commit. |
|
Ah damnit you're right, sorry. |
This reverts commit 413c2b6.
FroMage
force-pushed
the
safer-annotation-fix
branch
from
af83ad3
to
8af714d
Compare
quarkus-bot
bot
added
area/dependencies
|
That should be better. |
Failing Jobs - Building 8af714d
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 integration-tests/grpc-streaming✖ |
gsmet
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Safer Annotations because some vscode/eclipse implementations are even more broken than javac.