Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify NativeBuildReport usage via jbang in GH workflows #17528

Merged
merged 1 commit into from
May 31, 2021
Merged

Unify NativeBuildReport usage via jbang in GH workflows #17528

merged 1 commit into from
May 31, 2021

Conversation

famod
Copy link
Member

@famod famod commented May 28, 2021

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label May 28, 2021
gastaldi
gastaldi approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Another way is to use the JBang GitHub Action image, like in https://github.com/quarkusio/quarkus-extension-catalog/blob/main/.github/workflows/publish.yaml#L26

gsmet
gsmet reviewed May 31, 2021
View reviewed changes
.github/workflows/native-cron-build.yml.disabled
echo Installing SDKMAN
curl -s "https://get.sdkman.io" | bash
source ~/.sdkman/bin/sdkman-init.sh && \
sdk install jbang 0.21.0
[[ ${JAVA_VERSION} = 8 ]] && ISSUE_NUMBER="6717" || ISSUE_NUMBER="6723"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we don't support JDK 8 anymore, we could simplify further, couldn't we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit on the fence about this one but yeah, dropping this predicate makes sense.

@famod
Copy link
Member Author

famod commented May 31, 2021 •
edited

@gastaldi

Another way is to use the JBang GitHub Action image, like in https://github.com/quarkusio/quarkus-extension-catalog/blob/main/.github/workflows/publish.yaml#L26

That's what I first had for the JDK EA job but unfortunately, /opt/hostedtoolscache is not mounted into the container and so jbang (in the container) sees JAVA_HOME pointing to an unavailable path. This is very much a problem on GH's behalf, not specifically the jbang action's fault.
This only happens if the workflow uses one of those popular actions to set up a specific JDK. If you use the OOTB one then you're fine.

@gsmet gsmet merged commit b6567c5 into quarkusio:main May 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone May 31, 2021
@famod famod deleted the unify-jbang-report branch July 4, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@famod @gastaldi @gsmet