Ensure that VertxInputStream doesn't result in infinite attempts to read data #17546
Conversation
…ead data This change is needed because Netty now calls available to determine whether or not more bytes are available, before calling read. The negative value that we used to use does not play well with PushbackInputStream which is used by Netty to wrap the stream. For a full description of how I can came to this, see quarkusio#17506 (comment) Fixes: quarkusio#17506
|
Also cc @vietj who might have a better idea about this |
|
What is actually calling available() in our InputStream? I don't really understand the code path where our InputStream ends up being used by Netty? |
|
@stuartwdouglas see the comment I linked to (which contains a link to a Netty PR). |
|
How does Netty get our VertxInputStream? Netty does everything non blocking and this is a blocking class that we explose to the users application, so I am not sure how it gets passed down into Netty? |
|
It likely only happens in the case of #17506 where the application is actually buffering the InputStream and using a library for HTTP calls ( |
This change is needed because Netty now calls available to determine
whether or not more bytes are available, before calling read.
The negative value that we used to use does not play well with
PushbackInputStream which is used by Netty to wrap the stream.
For a full description of how I can came to this, see
#17506 (comment)
Fixes: #17506