SmallRye GraphQL Client: remove hard dependency on Rest client #17556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1d8db50
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/smallrye-graphql-client✖ ⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/smallrye-graphql-client✖ ⚙️ JVM Tests - JDK 16 #📦 integration-tests/smallrye-graphql-client✖ ⚙️ Native Tests - Misc3 #📦 integration-tests/smallrye-graphql-client✖ |
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
cescoffier
approved these changes
May 31, 2021
phillip-kruger
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hard dependency on Rest Client, so that client can choose the client they want to use (normal/reactive)
Future releases of SmallRye GraphQL Client will remove the dependency on Rest Client.
Signed-off-by:Phillip Kruger phillip.kruger@gmail.com