Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project's Quarkus version when resolving extension catalogs using a registry client #17585

Conversation

aloubyansky
Copy link
Member

Without this change registry client-based approach will be ignoring the Quarkus version used in an existing project.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 1, 2021
@aloubyansky aloubyansky requested a review from ia3andy June 1, 2021 10:07
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloubyansky aloubyansky merged commit 56b3d65 into quarkusio:main Jun 1, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 1, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants