Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete BrotliDecoder and let GraalVM DCE do it for us #17604

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 1, 2021

No description provided.

@zakkak
Copy link
Contributor

zakkak commented Jun 1, 2021

Please don't merge this before https://github.com/graalvm/mandrel/actions/runs/897038267 completes (testing it against Mandrel 21.1.0).

@zakkak
Copy link
Contributor

zakkak commented Jun 1, 2021

CI passed, so that's OK to be merged.

I am not sure I understand why we "We need to delete this class" though. Is this to prevent users from trying to use brotli due to some known issue with native-image?

@gsmet
Copy link
Member Author

gsmet commented Jun 1, 2021

No it's because it doesn't work right now (it uses some native library and work is needed to make it work).

@cescoffier
Copy link
Member

@zakkak should be fine no?

@gsmet gsmet merged commit 565d3f6 into quarkusio:main Jun 2, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 2, 2021
@zakkak
Copy link
Contributor

zakkak commented Jun 2, 2021

No it's because it doesn't work right now (it uses some native library and work is needed to make it work).

In that case it would be nice to have a GH issue and link to it in the comment so that we can better track it.

@zakkak should be fine no?

Yup it's fine!

@gsmet
Copy link
Member Author

gsmet commented Jun 2, 2021

Frankly, except if someone from the community is complaining and wants to implement it, I don't think any of us will have the time nor the willingness to look into it. That's why I haven't created an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants