Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OpenTelemetry REST Client filter into hidden extension #17608

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Move OpenTelemetry REST Client filter into hidden extension #17608

merged 1 commit into from
Jun 1, 2021

Conversation

kenfinnigan
Copy link
Member

@kenfinnigan kenfinnigan commented Jun 1, 2021 •
edited

Resolves #17385

  • Moves REST Client filter into a separate hidden extension
  • Uses Quarkus conditional dependency handling to only include the OpenTelemetry Rest Client extension if quarkus-rest-client is present in a user application

cc @pilhuhn

@kenfinnigan kenfinnigan added this to the 2.1 - main milestone Jun 1, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Jun 1, 2021
@kenfinnigan kenfinnigan changed the title Resolves #17385 Move OpenTelemetry REST Client filter into hidden extension Jun 1, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3c68c67

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Verify extension dependencies ⚠️ Check → Logs Raw logs

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Jun 1, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 84f4b3e

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@kenfinnigan
Resolves quarkusio#17385
1dd5a03 
- Moves REST Client filter into a separate hidden extension
- Uses Quarkus conditional dependency handling to only include the OpenTelemetry Rest Client extension if `quarkus-rest-client` is present in user application
@kenfinnigan kenfinnigan merged commit d7460d3 into quarkusio:main Jun 1, 2021
@kenfinnigan kenfinnigan deleted the otel-rest-client branch June 2, 2021 13:17
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebullient ebullient ebullient approved these changes

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/tracing
Projects
None yet
Milestone
2.0.0.CR3
Development

Successfully merging this pull request may close these issues.

MP RestClient calls fail if OpenTelemetry is in list of dependencies
4 participants
@kenfinnigan @ebullient @radcortez @gsmet