Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize io.vertx.ext.auth.impl.jose.JWT at runtime #17660

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 3, 2021

It contains a Random field so we can't initialize it at static init.

Fixes #17657

It contains a Random field so we can't initialize it at static init.

Fixes quarkusio#17657
@sberyozkin
Copy link
Member

Can that lead to some warnings in the logs that a given class is not available since this dependency is not included ?

@sberyozkin
Copy link
Member

I'm just wondering is it up to the custom application to ensure this class is runtime initialized with the config options

@gsmet
Copy link
Member Author

gsmet commented Jun 3, 2021

@sberyozkin the class is in vertx-auth-common which is a dependency of quarkus-vertx-http. That's why I did it this way.

@gsmet gsmet merged commit 98e0ff5 into quarkusio:main Jun 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 3, 2021
@sberyozkin
Copy link
Member

@gsmet I see, thanks for the explanation

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants