Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for @Cache and @NoCache #17661

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Add documentation for @Cache and @NoCache #17661

merged 1 commit into from
Jun 3, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 3, 2021

Follows up on #17644

@geoand geoand requested a review from FroMage June 3, 2021 09:27
@geoand geoand force-pushed the rr-cache-doc branch 2 times, most recently from e0de9a6 to 26bc85d Compare June 3, 2021 09:30
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 8dcaf6f

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building e0de9a6

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Set up job ⚠️ Check → Logs Raw logs
⌛ Attach pull request number Set up job ⚠️ Check → Logs Raw logs
⌛ CI Sanity Check Build ⚠️ Check → Logs Raw logs

FroMage
FroMage requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes, but otherwise LGTM.

docs/src/main/asciidoc/resteasy-reactive.adoc Outdated Show resolved Hide resolved
...ects/resteasy-reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/NoCache.java Outdated Show resolved Hide resolved
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 26bc85d

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand @FroMage
Add documentation for @Cache and @nocache
a08cab1 
Follows up on quarkusio#17644

Co-authored-by: Stéphane Épardaud <stef@inforealm.org>
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 045057d

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs

@geoand geoand requested a review from FroMage June 3, 2021 09:46
@FroMage
Copy link
Member

FroMage commented Jun 3, 2021

Great, thanks!

@geoand geoand merged commit 707153c into quarkusio:main Jun 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 3, 2021
@geoand geoand deleted the rr-cache-doc branch June 3, 2021 11:38
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.0.0.CR3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoand @FroMage @gsmet