-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid the Caffeine overhead when it's not used #17748
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building bf5cd12
Full information is available in the Build summary check run. Test Failures⚙️ Native Tests - Cache #📦 integration-tests/cache✖ 📦 integration-tests/infinispan-cache-jpa✖ 📦 integration-tests/infinispan-client✖ ⚙️ Native Tests - Data1 #📦 integration-tests/hibernate-tenancy✖ 📦 integration-tests/jpa-mssql✖ ⚙️ Native Tests - Data2 #📦 integration-tests/jpa-oracle✖ 📦 integration-tests/jpa✖ ⚙️ Native Tests - Data3 #📦 integration-tests/flyway✖ 📦 integration-tests/hibernate-orm-envers✖ 📦 integration-tests/hibernate-orm-panache✖ ⚙️ Native Tests - Data4 #📦 integration-tests/hibernate-orm-rest-data-panache✖ ⚙️ Native Tests - Data5 #📦 integration-tests/hibernate-reactive-postgresql✖ 📦 integration-tests/jpa-postgresql✖ ⚙️ Native Tests - Data6 #📦 integration-tests/hibernate-reactive-panache✖ 📦 integration-tests/hibernate-search-orm-elasticsearch✖ ⚙️ Native Tests - Data7 #📦 integration-tests/hibernate-reactive-db2✖ 📦 integration-tests/hibernate-reactive-mysql✖ ⚙️ Native Tests - Misc1 #📦 integration-tests/qute✖ ⚙️ Native Tests - Misc2 #📦 integration-tests/hibernate-validator✖ ⚙️ Native Tests - Misc4 #📦 integration-tests/micrometer-prometheus✖ ⚙️ Native Tests - Security3 #📦 integration-tests/vault-app✖ ⚙️ Native Tests - Spring #📦 integration-tests/spring-data-jpa✖ 📦 integration-tests/spring-data-rest✖ ⚙️ Native Tests - Windows - hibernate-validator #📦 integration-tests/hibernate-validator✖ |
"com.github.benmanes.caffeine.cache.SSMSA", | ||
"com.github.benmanes.caffeine.cache.SSMSW", | ||
"com.github.benmanes.caffeine.cache.SSW", | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. the list has grown slightly, as I've merged the missing ones from the (now deleted) duplicate registrations that were being triggered by https://github.com/quarkusio/quarkus/pull/17748/files#diff-b8f55d2a209ec481eaa58dee37f596a382aa4443a9585ae00581fcfac9a9c8b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I'm wondering if we could be even more clever and register the classes depending on the options used in the DSL. But given how many combinations there are, it would probably be impractical.
Added a small comment about the groupId/domain name we normally use.
...ne/runtime/src/main/java/io/quarkus/caffeine/runtime/graal/CacheConstructorsAutofeature.java
Outdated
Show resolved
Hide resolved
...ne/runtime/src/main/java/io/quarkus/caffeine/runtime/graal/CacheConstructorsAutofeature.java
Outdated
Show resolved
Hide resolved
+1 There are likely further ways to pre-filter this list. I'm not sure if I can look at that immediately though, I'd suggest to merge this and then we can see what else is possible. |
rebased to apply your suggestions on clean history |
right looks like I can easily split the list in two... I'll do it soon. |
@gsmet woot, all green on CI |
No description provided.