Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the Caffeine overhead when it's not used #17748

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jun 7, 2021

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building bf5cd12

Status Name Step Test failures Logs Raw logs
Native Tests - Cache Build Test failures Logs Raw logs
Native Tests - Data1 Build Test failures Logs Raw logs
Native Tests - Data2 Build Test failures Logs Raw logs
Native Tests - Data3 Build Test failures Logs Raw logs
Native Tests - Data4 Build Test failures Logs Raw logs
Native Tests - Data5 Build Test failures Logs Raw logs
Native Tests - Data6 Build Test failures Logs Raw logs
Native Tests - Data7 Build Test failures Logs Raw logs
Native Tests - Misc1 Build Test failures Logs Raw logs
Native Tests - Misc2 Build Test failures Logs Raw logs
Native Tests - Misc4 Build Test failures Logs Raw logs
Native Tests - Security3 Build Test failures Logs Raw logs
Native Tests - Spring Build Test failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - Cache #

📦 integration-tests/cache

io.quarkus.it.cache.CacheITCase.testCache - More details - Source on GitHub

📦 integration-tests/infinispan-cache-jpa

io.quarkus.it.infinispan.cache.jpa.InfinispanCacheJPAFunctionalityInGraalITCase.testEntityMemoryObjectCountOverride - More details - Source on GitHub

📦 integration-tests/infinispan-client

io.quarkus.it.infinispan.client.InfinispanClientFunctionalityInGraalITCase.testNearCacheInvalidation - More details - Source on GitHub


⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-tenancy

io.quarkus.it.hibernate.multitenancy.inventory.HibernateNamedPersistenceUnitTestInGraalITCase.testGetPlanesDefaultTenant - More details - Source on GitHub

📦 integration-tests/jpa-mssql

io.quarkus.it.jpa.mssql.JPAFunctionalityInGraalITCase.testJPAFunctionalityFromServlet - More details - Source on GitHub


⚙️ Native Tests - Data2 #

📦 integration-tests/jpa-oracle

io.quarkus.it.jpa.oracle.procedurecall.ProcedureCallInGraalITCase.test - More details - Source on GitHub

📦 integration-tests/jpa

io.quarkus.it.jpa.jdbcmetadata.JPAJdbcMetadataRetrievalInGraalITCase.test - More details - Source on GitHub


⚙️ Native Tests - Data3 #

📦 integration-tests/flyway

io.quarkus.it.flyway.FlywayFunctionalityNativeIT.testPlaceholders - More details - Source on GitHub

📦 integration-tests/hibernate-orm-envers

io.quarkus.it.envers.JPAEnversTestInGraalITCase.testProjectAtRevisionJpa - More details - Source on GitHub

📦 integration-tests/hibernate-orm-panache

io.quarkus.it.panache.PanacheFunctionalityInGraalITCase.testBug5274 - More details - Source on GitHub


⚙️ Native Tests - Data4 #

📦 integration-tests/hibernate-orm-rest-data-panache

io.quarkus.it.hibernate.orm.rest.data.panache.HibernateOrmRestDataPanacheIT.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub


⚙️ Native Tests - Data5 #

📦 integration-tests/hibernate-reactive-postgresql

io.quarkus.it.hibernate.reactive.postgresql.HibernateReactiveInGraalIT.reactiveFind - More details - Source on GitHub

📦 integration-tests/jpa-postgresql

io.quarkus.it.jpa.postgresql.JPAFunctionalityInGraalITCase.testJPAFunctionalityFromServlet - More details - Source on GitHub


⚙️ Native Tests - Data6 #

📦 integration-tests/hibernate-reactive-panache

io.quarkus.it.panache.reactive.PanacheFunctionalityInGraalITCase.testBug5274 - More details - Source on GitHub

📦 integration-tests/hibernate-search-orm-elasticsearch

io.quarkus.it.hibernate.search.elasticsearch.HibernateSearchInGraalIT.testSearch - More details - Source on GitHub


⚙️ Native Tests - Data7 #

📦 integration-tests/hibernate-reactive-db2

io.quarkus.it.hibernate.reactive.db2.HibernateReactiveDB2AlternativeInGraalIT.reactiveFind - More details - Source on GitHub

📦 integration-tests/hibernate-reactive-mysql

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLInGraalIT.reactiveFind - More details - Source on GitHub


⚙️ Native Tests - Misc1 #

📦 integration-tests/qute

io.quarkus.it.qute.QuteITCase.testTemplates - More details - Source on GitHub


⚙️ Native Tests - Misc2 #

📦 integration-tests/hibernate-validator

io.quarkus.it.hibernate.validator.HibernateValidatorFunctionalityInGraalITCase.testCDIBeanMethodValidation - More details - Source on GitHub


⚙️ Native Tests - Misc4 #

📦 integration-tests/micrometer-prometheus

io.quarkus.it.micrometer.prometheus.PrometheusMetricsRegistryIT.testRegistryInjection - More details - Source on GitHub


⚙️ Native Tests - Security3 #

📦 integration-tests/vault-app

io.quarkus.it.vault.VaultInGraalITCase.test - More details - Source on GitHub


⚙️ Native Tests - Spring #

📦 integration-tests/spring-data-jpa

io.quarkus.it.spring.data.jpa.MovieResourceIT.testCountByRating - More details - Source on GitHub

📦 integration-tests/spring-data-rest

io.quarkus.it.spring.data.rest.SpringDataRestIT.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub


⚙️ Native Tests - Windows - hibernate-validator #

📦 integration-tests/hibernate-validator

io.quarkus.it.hibernate.validator.HibernateValidatorFunctionalityInGraalITCase.testCDIBeanMethodValidation - More details - Source on GitHub

"com.github.benmanes.caffeine.cache.SSMSA",
"com.github.benmanes.caffeine.cache.SSMSW",
"com.github.benmanes.caffeine.cache.SSW",
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. the list has grown slightly, as I've merged the missing ones from the (now deleted) duplicate registrations that were being triggered by https://github.com/quarkusio/quarkus/pull/17748/files#diff-b8f55d2a209ec481eaa58dee37f596a382aa4443a9585ae00581fcfac9a9c8b3

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I'm wondering if we could be even more clever and register the classes depending on the options used in the DSL. But given how many combinations there are, it would probably be impractical.

Added a small comment about the groupId/domain name we normally use.

@Sanne
Copy link
Member Author

Sanne commented Jun 8, 2021

Interesting. I'm wondering if we could be even more clever and register the classes depending on the options used in the DSL. But given how many combinations there are, it would probably be impractical.

+1 There are likely further ways to pre-filter this list.

I'm not sure if I can look at that immediately though, I'd suggest to merge this and then we can see what else is possible.

@Sanne
Copy link
Member Author

Sanne commented Jun 8, 2021

rebased to apply your suggestions on clean history

@quarkusio quarkusio deleted a comment from quarkus-bot bot Jun 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ff72ff3

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@Sanne
Copy link
Member Author

Sanne commented Jun 8, 2021

right looks like I can easily split the list in two... I'll do it soon.

@Sanne
Copy link
Member Author

Sanne commented Jun 8, 2021

@gsmet woot, all green on CI

@gsmet gsmet merged commit b0aa5b0 into quarkusio:main Jun 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
@Sanne Sanne deleted the CaffeineOpt branch June 9, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants