Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wildfly-elytron.version from 1.15.4.Final to 1.16.0.Final #17816

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 9, 2021

Bumps wildfly-elytron.version from 1.15.4.Final to 1.16.0.Final.
Updates wildfly-elytron from 1.15.4.Final to 1.16.0.Final

Commits
  • 68b2864 [ELY-2133] Release WildFly Elytron 1.16.0.Final
  • c2790c2 Merge pull request #1533 from ivassile/ELY-2131
  • 48d9113 Merge pull request #1532 from Ashpan/ELY-2127
  • c1ad229 Merge pull request #1531 from darranl/ELY-2088
  • b7ad0ce [ELY-2131] Possible NullPointerException in JwtValidator when validating
  • ea9a093 [ELY-2127] Add client side TRACE logging after successful authentication
  • d63cbe1 [ELY-2088] Revert "[ELY-1626] Temporary commit to preserve API compatibility ...
  • 593621c Next is CR2
  • 2089734 [ELY-2129] Release WildFly Elytron 1.16.0.CR1
  • 0bc21f1 Merge pull request #1440 from SoniaZaldana/ELY-2001
  • Additional commits viewable in compare view

Updates wildfly-elytron-auth-server from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-password-impl from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-realm from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-realm-token from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-realm-jdbc from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-realm-ldap from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-ssl from 1.15.4.Final to 1.16.0.Final

Commits
  • 68b2864 [ELY-2133] Release WildFly Elytron 1.16.0.Final
  • c2790c2 Merge pull request #1533 from ivassile/ELY-2131
  • 48d9113 Merge pull request #1532 from Ashpan/ELY-2127
  • c1ad229 Merge pull request #1531 from darranl/ELY-2088
  • b7ad0ce [ELY-2131] Possible NullPointerException in JwtValidator when validating
  • ea9a093 [ELY-2127] Add client side TRACE logging after successful authentication
  • d63cbe1 [ELY-2088] Revert "[ELY-1626] Temporary commit to preserve API compatibility ...
  • 593621c Next is CR2
  • 2089734 [ELY-2129] Release WildFly Elytron 1.16.0.CR1
  • 0bc21f1 Merge pull request #1440 from SoniaZaldana/ELY-2001
  • Additional commits viewable in compare view

Updates wildfly-elytron-sasl-plain from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-sasl-digest from 1.15.4.Final to 1.16.0.Final

Commits
  • 68b2864 [ELY-2133] Release WildFly Elytron 1.16.0.Final
  • c2790c2 Merge pull request #1533 from ivassile/ELY-2131
  • 48d9113 Merge pull request #1532 from Ashpan/ELY-2127
  • c1ad229 Merge pull request #1531 from darranl/ELY-2088
  • b7ad0ce [ELY-2131] Possible NullPointerException in JwtValidator when validating
  • ea9a093 [ELY-2127] Add client side TRACE logging after successful authentication
  • d63cbe1 [ELY-2088] Revert "[ELY-1626] Temporary commit to preserve API compatibility ...
  • 593621c Next is CR2
  • 2089734 [ELY-2129] Release WildFly Elytron 1.16.0.CR1
  • 0bc21f1 Merge pull request #1440 from SoniaZaldana/ELY-2001
  • Additional commits viewable in compare view

Updates wildfly-elytron-sasl-external from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-sasl-oauth2 from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-sasl-scram from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-x500-cert from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-credential from 1.15.4.Final to 1.16.0.Final

Commits
  • 68b2864 [ELY-2133] Release WildFly Elytron 1.16.0.Final
  • c2790c2 Merge pull request #1533 from ivassile/ELY-2131
  • 48d9113 Merge pull request #1532 from Ashpan/ELY-2127
  • c1ad229 Merge pull request #1531 from darranl/ELY-2088
  • b7ad0ce [ELY-2131] Possible NullPointerException in JwtValidator when validating
  • ea9a093 [ELY-2127] Add client side TRACE logging after successful authentication
  • d63cbe1 [ELY-2088] Revert "[ELY-1626] Temporary commit to preserve API compatibility ...
  • 593621c Next is CR2
  • 2089734 [ELY-2129] Release WildFly Elytron 1.16.0.CR1
  • 0bc21f1 Merge pull request #1440 from SoniaZaldana/ELY-2001
  • Additional commits viewable in compare view

Updates wildfly-elytron-sasl-gs2 from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-asn1 from 1.15.4.Final to 1.16.0.Final

Commits
  • 68b2864 [ELY-2133] Release WildFly Elytron 1.16.0.Final
  • c2790c2 Merge pull request #1533 from ivassile/ELY-2131
  • 48d9113 Merge pull request #1532 from Ashpan/ELY-2127
  • c1ad229 Merge pull request #1531 from darranl/ELY-2088
  • b7ad0ce [ELY-2131] Possible NullPointerException in JwtValidator when validating
  • ea9a093 [ELY-2127] Add client side TRACE logging after successful authentication
  • d63cbe1 [ELY-2088] Revert "[ELY-1626] Temporary commit to preserve API compatibility ...
  • 593621c Next is CR2
  • 2089734 [ELY-2129] Release WildFly Elytron 1.16.0.CR1
  • 0bc21f1 Merge pull request #1440 from SoniaZaldana/ELY-2001
  • Additional commits viewable in compare view

Updates wildfly-elytron-sasl-gssapi from 1.15.4.Final to 1.16.0.Final

Updates wildfly-elytron-security-manager-action from 1.15.4.Final to 1.16.0.Final

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Jun 9, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1f3eaaa

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@gsmet gsmet requested a review from sberyozkin June 10, 2021 08:18
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 10, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1f3eaaa

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member

@darranl Hi Darran

JDK11 build fails with:

2021-06-10T08:30:36.5385386Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-elytron-security-jdbc: Compilation failure: Compilation failure: 
2021-06-10T08:30:36.5387644Z [ERROR] /home/runner/work/quarkus/quarkus/extensions/elytron-security-jdbc/runtime/src/main/java/io/quarkus/elytron/security/jdbc/BcryptPasswordKeyMapperConfig.java:[33,29] cannot find symbol
2021-06-10T08:30:36.5388742Z [ERROR]   symbol:   class Encoding
2021-06-10T08:30:36.5389817Z [ERROR]   location: class org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper
2021-06-10T08:30:36.5391820Z [ERROR] /home/runner/work/quarkus/quarkus/extensions/elytron-security-jdbc/runtime/src/main/java/io/quarkus/elytron/security/jdbc/BcryptPasswordKeyMapperConfig.java:[45,29] cannot find symbol
2021-06-10T08:30:36.5392897Z [ERROR]   symbol:   class Encoding
2021-06-10T08:30:36.5393968Z [ERROR]   location: class org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper

The affected source is here.

Can you clarify please how to handle it ? Should Quarkus continue staying on 1.15.x ?

@darranl
Copy link
Contributor

darranl commented Jun 10, 2021

@sberyozkin Would you consider configuring the PasswordKeyMapper part of your public API?

We hadn't flagged that class as public API so have accepted a breaking change - Encoding is now it's own enum org.wildfly.security.password.spec.Encoding

If you are exposing this we may be able to consider adding it back and deprecating it instead so you can continue with the later releases.

@sberyozkin
Copy link
Member

@darranl It is likely going to be OK for Quarkus 2.1.0, I don't see this enum used anywhere but in this configuration, and the users can't configure this extension manually, so their code is not tied to this enum.

@danielpetisme Can you see some possible issues if the code will change from

import org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper;
/**
 * Configuration information used to populate a "bcrypt"
 * {@linkplain org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper}
 */
@ConfigGroup
public class BcryptPasswordKeyMapperConfig implements PasswordKeyMapperConfig {

    /**
     * A string referencing the salt encoding ("BASE64" or "HEX")
     */
    @ConfigItem(defaultValue = "BASE64")
    public PasswordKeyMapper.Encoding saltEncoding;

}

to

import org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper;
import org.wildfly.security.password.spec.Encoding;
/**
 * Configuration information used to populate a "bcrypt"
 * {@linkplain org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper}
 */
@ConfigGroup
public class BcryptPasswordKeyMapperConfig implements PasswordKeyMapperConfig {

    /**
     * A string referencing the salt encoding ("BASE64" or "HEX")
     */
    @ConfigItem(defaultValue = "BASE64")
    public Encoding saltEncoding;
}

? Let me know please, I'll update if you are OK with it

Bumps `wildfly-elytron.version` from 1.15.4.Final to 1.16.0.Final.

Updates `wildfly-elytron` from 1.15.4.Final to 1.16.0.Final
- [Release notes](https://github.com/wildfly-security/wildfly-elytron/releases)
- [Commits](wildfly-security/wildfly-elytron@1.15.4.Final...1.16.0.Final)

Updates `wildfly-elytron-auth-server` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-password-impl` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-realm` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-realm-token` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-realm-jdbc` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-realm-ldap` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-ssl` from 1.15.4.Final to 1.16.0.Final
- [Release notes](https://github.com/wildfly-security/wildfly-elytron/releases)
- [Commits](wildfly-security/wildfly-elytron@1.15.4.Final...1.16.0.Final)

Updates `wildfly-elytron-sasl-plain` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-sasl-digest` from 1.15.4.Final to 1.16.0.Final
- [Release notes](https://github.com/wildfly-security/wildfly-elytron/releases)
- [Commits](wildfly-security/wildfly-elytron@1.15.4.Final...1.16.0.Final)

Updates `wildfly-elytron-sasl-external` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-sasl-oauth2` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-sasl-scram` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-x500-cert` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-credential` from 1.15.4.Final to 1.16.0.Final
- [Release notes](https://github.com/wildfly-security/wildfly-elytron/releases)
- [Commits](wildfly-security/wildfly-elytron@1.15.4.Final...1.16.0.Final)

Updates `wildfly-elytron-sasl-gs2` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-asn1` from 1.15.4.Final to 1.16.0.Final
- [Release notes](https://github.com/wildfly-security/wildfly-elytron/releases)
- [Commits](wildfly-security/wildfly-elytron@1.15.4.Final...1.16.0.Final)

Updates `wildfly-elytron-sasl-gssapi` from 1.15.4.Final to 1.16.0.Final

Updates `wildfly-elytron-security-manager-action` from 1.15.4.Final to 1.16.0.Final

---
updated-dependencies:
- dependency-name: org.wildfly.security:wildfly-elytron
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-auth-server
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-password-impl
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-realm
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-realm-token
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-realm-jdbc
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-realm-ldap
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-ssl
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-plain
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-digest
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-external
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-scram
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-x500-cert
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-credential
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-gs2
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-asn1
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-sasl-gssapi
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.wildfly.security:wildfly-elytron-security-manager-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@sberyozkin sberyozkin force-pushed the dependabot/maven/wildfly-elytron.version-1.16.0.Final branch from 1f3eaaa to eab2a2b Compare June 26, 2021 17:15
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 26, 2021

Failing Jobs - Building eab2a2b

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member

@danielpetisme Hi, I've done this update and it looks fine, tests are good, so let me merge it, I don't see how this change should affect the extension, hope it all will be fine

MP TCK test failure is unrelated

@sberyozkin sberyozkin merged commit 775c69c into main Jun 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 27, 2021
@sberyozkin sberyozkin deleted the dependabot/maven/wildfly-elytron.version-1.16.0.Final branch June 27, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants