Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Dev Services for AMQP #17844

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Implement Dev Services for AMQP #17844

merged 1 commit into from
Jun 14, 2021

Conversation

cescoffier
Copy link
Member

A shameless copy of the Kafka one but for AMQP.

@cescoffier cescoffier requested a review from Ladicek June 10, 2021 17:33
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 10, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@cescoffier cescoffier changed the title Implement Dev Services for AMQP. Implement Dev Services for AMQP Jun 10, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 11, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building defc90f

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@cescoffier
Copy link
Member Author

Thanks @machi1990 for the reviews! I fixed all your comment (I should never copy/paste field names...)

Ladicek
Ladicek approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd just get rid of the vromero image.

@cescoffier
Implement Dev Services for AMQP.
928866b 
Swtich from the vromero image to artemiscloud image to start the AMQP broker.
@cescoffier cescoffier added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 14, 2021
@cescoffier cescoffier removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 14, 2021
@cescoffier cescoffier merged commit efeaf52 into quarkusio:main Jun 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 14, 2021
@cescoffier cescoffier deleted the amqp-dev-service branch June 14, 2021 13:38
@vkasala vkasala mentioned this pull request Aug 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@geoand geoand geoand approved these changes

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
area/documentation area/reactive-messaging area/smallrye
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cescoffier @Ladicek @geoand @machi1990