Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panache: Support collections in Hibernate Filters #17917

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Panache: Support collections in Hibernate Filters #17917

merged 1 commit into from
Jun 16, 2021

Conversation

Sgitario
Copy link
Contributor

This PR allows to filter by collections using Panache:

@FilterDef(name = "nameFilter", parameters = {@ParamDef(name = "names", type = "string")})
@Filter(name = "nameFilter", condition = "name in (:names)")
public class Person extends PanacheEntity {
// ...
}

Fix #13832

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e62c169

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand geoand requested a review from FroMage June 15, 2021 09:25
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d4766cc

Status Name Step Test failures Logs Raw logs
✖ Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs

@Sgitario
Copy link
Contributor Author

Failing Jobs - Building d4766cc

Status Name Step Test failures Logs Raw logs
Native Tests - Misc4 Build Check → Logs Raw logs

I think this failure is unrelated to this PR. cc @FroMage

FroMage
FroMage approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@Sgitario
Panache: Support collections in Hibernate Filters
a8072cc 
This PR allows to filter by collections using Panache:

```java
@FilterDef(name = "nameFilter", parameters = {@ParamDef(name = "names", type = "string")})
@filter(name = "nameFilter", condition = "name in (:names)")
public class Person extends PanacheEntity {
// ...
}
```
@Sgitario
Copy link
Contributor Author

I've just rebased this PR.

@FroMage FroMage merged commit 8ea4569 into quarkusio:main Jun 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/panache
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

PanacheEntityBase: support collections in Hibernate filters
2 participants
@Sgitario @FroMage