Apply some micro-optimizations to logging setup code

[geoand]

• Replace map iteration using entrySet with forEach (@Sanne has mentioned that this is much faster)
• Get rid of lambdas
• Don't allocate various datastructures unless necessary

I took this up when looking at #17914

[Sanne]

Replace map iteration using entrySet with forEach (@Sanne has mentioned that this is much faster)

hum let me qualify that :) I said it's sometimes better because the forEach idiom can avoid allocating an Iterator - but iterators aren't super expensive so this would still depend on context and other details.
In this case to skip allocating an iterator it seems you have to allocate other objects to support this - including multiple BiFunction instances - so it might very well be that the entrySet approach was cheaper?

I just glanced at it though so I'm not sure - just making sure what I said isn't misunderstood :)

[Sanne]

BTW a great way to make it easy for a reviewer to actually see the refactoring will be beneficial is to use methodhandles, as they won't hide capturing lambdas. Also if you can't crack the puzzle with methodhandles, it's a hint that you're needing to allocate something else for context... so I really like them

[geoand]

Replace map iteration using entrySet with forEach (@Sanne has mentioned that this is much faster)

hum let me qualify that :) I said it's sometimes better because the forEach idiom can avoid allocating an Iterator - but iterators aren't super expensive so this would still depend on context and other details.
In this case to skip allocating an iterator it seems you have to allocate other objects to support this - including multiple BiFunction instances - so it might very well be that the entrySet approach was cheaper?

I took a look at what entrySet() needs to allocate in order to support it's operation and it seems to be much more than the single BiConsumer that is needed here :)

[Sanne]

Approved pending CI (I didn't test it!)

Thanks @geoand !

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building ff0064a

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Devtools Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	Build	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	Verify	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Amazon	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Cache		⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data1	Set up JDK 11	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data2	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data3	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data4	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data5	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data6	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data7	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Main	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Windows - hibernate-validator		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

[geoand]

Thanks @geoand !

Thanks for checking!