Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AroundConstruct methods to return Object. Fixes #1791 #1794

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Allow AroundConstruct methods to return Object. Fixes #1791 #1794

merged 1 commit into from
Apr 2, 2019

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Apr 1, 2019

#1791

@mkouba please review. I also added a test, not sure if this is the right testing strategy you had in mind :)

@jmartisk
Copy link
Contributor Author

jmartisk commented Apr 2, 2019

Ready for a new review. I didn't do validation checks for other interception types than AroundConstruct so we might add them later :)

@mkouba mkouba merged commit e25204a into quarkusio:master Apr 2, 2019
@jmartisk jmartisk deleted the master-issue-1791 branch April 2, 2019 08:43
@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
@jmartisk jmartisk added the area/arc Issue related to ARC (dependency injection) label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmartisk @mkouba @gsmet