Use the GraalVM API instead of flag to force build-time init #17986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Jun 17, 2021
|
Looks good, but I wonder why we generate code when it's always going to be the same call? Couldn't we have an easy-to-edit automatic feature? |
|
We could yeah, it's just what we have now that I changed. |
|
@maxandersen are you also okay with this? |
|
Looks ok to me. I have simalar thoughts as @Sanne that an explicit feature might be better in the long run. |
|
Sure, we should check was I mentioned above in that direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #17887