Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align jquery version to 3.5.1 #18023

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Align jquery version to 3.5.1 #18023

merged 1 commit into from
Jun 21, 2021

Conversation

m1ngyuan
Copy link
Contributor

No description provided.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 21, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cba2fd7

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorDevModeTest.testDevMode line 54 - More details - Source on GitHub

✖ io.quarkus.webjar.locator.test.WebJarLocatorTest.test line 45 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorDevModeTest.testDevMode line 54 - More details - Source on GitHub

✖ io.quarkus.webjar.locator.test.WebJarLocatorTest.test line 45 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorDevModeTest.testDevMode line 54 - More details - Source on GitHub

✖ io.quarkus.webjar.locator.test.WebJarLocatorTest.test line 45 - More details - Source on GitHub

@gsmet gsmet merged commit caf912c into quarkusio:main Jun 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 21, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 21, 2021
@m1ngyuan m1ngyuan deleted the align_jquery branch June 21, 2021 11:41
famod
famod reviewed Jun 21, 2021
View reviewed changes
...ocator/deployment/src/test/java/io/quarkus/webjar/locator/test/WebJarLocatorDevModeTest.java
@@ -50,7 +50,7 @@ public void testDevMode() {
.statusCode(200);

// Test using version in url of existing Web Jar
RestAssured.get("/webjars/jquery/3.4.1/jquery.min.js").then()
RestAssured.get("/webjars/jquery/3.5.1/jquery.min.js").then()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet Isn't that going to break as soon as someone bumps the value of the property?
A sustainable solution would be to reuse the property here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m1ngyuan @gsmet @famod