Kafka reference guide #18085
Merged
Kafka reference guide #18085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
Jul 8, 2021
| In the absence of acknowledgment, the processing is considered on error. | ||
| If the consumer method receives a `Record` or a payload, the message will be acked on method return, also known as `Strategy.POST_PROCESSING`. | ||
| If the consumer method returns another reactive stream or `CompletableStage`, the message will be acked when the downstream message is acked. | ||
| // No, it will be ack then the produced message get acked -> Needs confirmation |
docs/src/main/asciidoc/kafka.adoc
Outdated
| You can also remove the limit of in-flight messages by setting `max-inflight-messages` to `0`. | ||
| However, note that the Kafka Producer may block if the number of requests reaches `max.in.flight.requests.per.connection`. | ||
|
|
||
| === Retries |
There was a problem hiding this comment.
Should it be under the producing message section?
There was a problem hiding this comment.
I think we can rename this section to "Retrying message dispatch" and keep it here. I was thinking of adding the "Retrying processing" section near receiving messages/error handling. What do you think ?
cescoffier
requested changes
Jul 9, 2021
cescoffier
reviewed
Jul 9, 2021
|
|
||
| For example, if you need to send a message to a stream, from inside a REST endpoint, when receiving a POST request. | ||
| In this case, you cannot use `@Outgoing` because your method has parameters. | ||
| == Accessing Kafka clients directly |
There was a problem hiding this comment.
Add an anchor as this should be referenced from the getting started guide.
There was a problem hiding this comment.
Added the reference to the getting started guide
ozangunalp
force-pushed
the
kafka-reference-guide
branch
from
e257c88
to
263d788
Compare
cescoffier
approved these changes
Jul 9, 2021
|
@ozangunalp can you squash your commits? |
ozangunalp
force-pushed
the
kafka-reference-guide
branch
from
263d788
to
0e6149d
Compare
|
@cescoffier done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform Getting started to Reference Guide
Links to other guides : Avro Serialization & Schema Registry, Kafka Streams, Dev Services