Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTEL Docs #18088

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Update OTEL Docs #18088

merged 1 commit into from
Jun 22, 2021

Conversation

luneo7
Copy link
Contributor

@luneo7 luneo7 commented Jun 22, 2021

Updates OpenTelemetry docs to reflect latest changes in the extension.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021

/cc @kenfinnigan

@@ -20,16 +20,6 @@
/** Build / static runtime config for span exporters */
public SpanExporterConfig exporter;

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this leftover was merged, and now I am removing it =/

Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments otherwise looks great.

Thanks!

docs/src/main/asciidoc/opentelemetry.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/opentelemetry.adoc Show resolved Hide resolved
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 6172f47

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@kenfinnigan
Copy link
Member

@luneo7 FYI, JDK 11 build failed because the imports aren't sorted.

Can you do an mvn package on the extension to fix it? Thanks

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building ef1f2bf

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@kenfinnigan kenfinnigan merged commit b1f522f into quarkusio:main Jun 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants