Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mutiny boms instead of listing all dependencies individually #18096

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

cescoffier
Copy link
Member

Use the Mutiny BOMs instead of listing the dependencies individually.
There are two boms:

  • the mutiny bom - Mutiny API and related projects
  • the Mutiny Vert.x Bindings - Provides the Vert.x Mutiny APIs (clients, core...)

@cescoffier cescoffier requested a review from jponge June 23, 2021 08:03
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jun 23, 2021
gsmet
gsmet previously requested changes Jun 23, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a question. Would prefer clarification before merging. Feel free to dismiss once done.

bom/application/pom.xml Outdated Show resolved Hide resolved
@gsmet gsmet dismissed their stale review June 23, 2021 09:37

Question answered.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 0f391f0

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

@cescoffier cescoffier merged commit 33b812f into quarkusio:main Jun 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 23, 2021
@cescoffier cescoffier deleted the use-mutiny-boms branch June 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants