Make minor improvements to various RESTEasy Reactive classes that iterate through maps #18102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rate through maps We remove the use of entrySet() where it makes sense and replace it with forEach which faster and doesn't allocate additional objects
|
Something @Sanne would likely enjoy :) |
Sanne
requested changes
Jun 23, 2021
| @@ -185,7 +185,7 @@ public AbstractResponseBuilder clone() { | |||
| responseBuilder.status = status; | |||
| responseBuilder.reasonPhrase = reasonPhrase; | |||
| responseBuilder.entity = entity; | |||
| responseBuilder.metadata = new QuarkusMultivaluedHashMap<>(); | |||
| responseBuilder.metadata = new CaseInsensitiveMap<>(); | |||
There was a problem hiding this comment.
How does this relate with the change?
There was a problem hiding this comment.
It's necessary in order to narrow the type of the map - it should have been done anyway
There was a problem hiding this comment.
Also see my comment below
...tive/common/runtime/src/main/java/org/jboss/resteasy/reactive/common/jaxrs/ResponseImpl.java
Show resolved
Hide resolved
It's great to be able to learn of such opportunities from the experts :) |
Sanne
reviewed
Jun 23, 2021
| return stringHeaders; | ||
| } | ||
|
|
||
| public void populateStringHeaders(String headerName, List<Object> values) { | ||
| List<String> stringValues = new ArrayList<>(values.size()); |
There was a problem hiding this comment.
I know it's not related to this PR, but allocating arrayslists in a tight loop for no other reason than to accomodate for the put method requirements ?! :)
There was a problem hiding this comment.
I'm open to suggestions :)
Sanne
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the use of
entrySet()where it makes sense and replace it withforEach()which faster and doesn't allocate additional objects