Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - deprecate Results.Result enum and introduce Results.NotFound #18110

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Qute - deprecate Results.Result enum and introduce Results.NotFound #18110

merged 1 commit into from
Jun 24, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 23, 2021 •
edited

  • in order to improve the error message when a property/method is not
    found
    • E.g. "Property not found in expression {bar.name} in template bar on line 1". becomes "Property "name" not found on base object "java.lang.String" in expression {bar.name} in template bar on line 1."
  • also use the quarkus.qute.property-not-found-strategy=throw-exception
    by default in the development mode
  • related to qute not handling missing getter well #16076

@quarkus-bot quarkus-bot bot added area/qute The template engine area/vertx labels Jun 23, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Jun 23, 2021

Note that this PR is a breaking change:

  1. The default behavior in the dev mode changed
  2. But the Results.NotFound change should not affect end users but merely some super advanced qute extension authors (who test the presence of the Results.Result.NOT_FOUND).

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 23, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cf45d4f

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 80 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 80 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 80 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.CreateProjectMojoIT.generateNewProjectAndRun line 454 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.CreateProjectMojoIT.generateNewProjectAndRun line 454 - More details - Source on GitHub

@mkouba
Qute - deprecate Results.Result enum and introduce Results.NotFound
a4531b0 
- in order to improve the error message when a property/method is not
found
- also use the quarkus.qute.property-not-found-strategy=throw-exception
by default in the development mode
- related to quarkusio#16076
@quarkus-bot quarkus-bot bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 24, 2021
@mkouba mkouba requested a review from gastaldi June 24, 2021 08:28
gastaldi
gastaldi approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job!

@mkouba mkouba merged commit 9ae00d5 into quarkusio:main Jun 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 24, 2021
mkouba added a commit to mkouba/quarkus that referenced this pull request Jun 30, 2021
@mkouba
Qute - fix performance regression caused by Results.NotFound
411cb17 
- follows up on quarkusio#18110
@mkouba mkouba mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/vertx
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkouba @gastaldi