Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - loop section - introduce the {#else} block #18127

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 24, 2021

  • this block is executed if there are no items to iterate

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building fec7081

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@mkouba mkouba added the area/qute The template engine label Jun 24, 2021
@mkouba mkouba added this to the 2.1 - main milestone Jun 24, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@gastaldi
Copy link
Contributor

@mkouba looks like it conflicts now with your other PR

@mkouba
Copy link
Contributor Author

mkouba commented Jun 24, 2021

@mkouba looks like it conflicts now with your other PR

Yep, I'll fix it...

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 61d0104

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/grpc-hibernate-reactive

com.example.reactive.ReactiveServiceTest.shouldWatchAndAddMultipleTimes line 45 - More details - Source on GitHub

- this block is executed if there are no items to iterate
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5d0a869

Status Name Step Test failures Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 25, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5d0a869

Status Name Step Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

@mkouba
Copy link
Contributor Author

mkouba commented Jun 25, 2021

It seems that the CI is currently somewhat unstable. Let's try for the last time...

@mkouba mkouba merged commit d3a042a into quarkusio:main Jun 25, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 25, 2021
@gsmet
Copy link
Member

gsmet commented Jul 1, 2021

This is a very good idea, can't wait to have it available as I was too lazy to cover the corner cases and with this, cost is ~0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants